[RESULT] [VOTE] Deprecate ResourceDecorator.decorate(Resource, HttpServletRequest)

[Justin Edelson <ju...@apache.org>]

The vote to deprecate ResourceDecorator.decorate(Resource,
HttpServletRequest) has passed with the following votes:

+1 (binding): Justin Edelson, Felix Meschberger, Bertrand Delacretaz
+1 (non-binding): Antonio Sanso

Note - Alexander Klimetschek originally voted +1, but privately
emailed me to retract his vote.

I will post a link to this thread on
https://issues.apache.org/jira/browse/SLING-2411 and make the
corresponding code and documentation changes.

On Fri, Feb 10, 2012 at 8:19 PM, Justin Edelson <ju...@apache.org> wrote:
> As described here: https://issues.apache.org/jira/browse/SLING-2411, we
> do not currently have a way of enforcing that ResourceResolver clients invoke
> resolve(HttpServletRequest, String) when they are doing a resolve
> inside a request
> context. The net effect of this is that implementors of ResourceDecorator have
> inconsistent results.
>
> I've uploaded a strawman patch to
> https://issues.apache.org/jira/browse/SLING-2411 to
> illustrate how this might be solved using a ThreadLocal. However, I
> personally feel
> like we should just go ahead and deprecate this method and I'd like to
> call a vote for it.
>
> Please vote:
> [ ] +1 - deprecate ResourceDecorator.decorate(Resource, HttpServletRequest)
> [ ] 0
> [ ] -1 - don't deprecate
>
> Note - if you vote -1, please provide an alternative. It could be the
> strawman, it could be
> something else, but I'd really like to see this fixed.
>
> Thanks
> Justin