You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/13 07:56:58 UTC

[GitHub] [incubator-nuttx] Gary-Hobson commented on pull request #7076: Remove duplicate calls and optimize compilation speed

Gary-Hobson commented on PR #7076:
URL: https://github.com/apache/incubator-nuttx/pull/7076#issuecomment-1245038893

   > LGTM with the following caveat: I only tested ARM builds with GCC, since that is the only platform for which I have a toolchain currently. Hopefully this doesn't break anything on any other platform or toolchain.
   > 
   > If someone has the ability to build the z80 target, or perhaps the sim target on Windows, that will give us some insight.
   
   I think this should be safe.
   This change doesn't modify any data, it just remembers the result of the first output.
   Of course it would be better if someone could verify it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org