You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "qianye1001 (via GitHub)" <gi...@apache.org> on 2025/04/23 01:54:06 UTC
[PR] [ISSUE #984] Support fifo parallel consume in java pushconsumer [rocketmq-clients]
qianye1001 opened a new pull request, #985:
URL: https://github.com/apache/rocketmq-clients/pull/985
<!-- Please make sure the target branch is right. In most case, the target branch should be `master`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #984
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #984] Support fifo parallel consume in java pushconsumer [rocketmq-clients]
Posted by "dingshuangxi888 (via GitHub)" <gi...@apache.org>.
dingshuangxi888 commented on code in PR #985:
URL: https://github.com/apache/rocketmq-clients/pull/985#discussion_r2055334132
##########
java/client-apis/src/main/java/org/apache/rocketmq/client/apis/consumer/PushConsumerBuilder.java:
##########
@@ -81,6 +81,14 @@ public interface PushConsumerBuilder {
*/
PushConsumerBuilder setConsumptionThreadCount(int count);
+ /**
+ * Set the fifo parallel processing.
+ *
+ * @param enableFifoParallelProcessing enable fifo parallel processing.
+ * @return the consumer builder instance.
+ */
+ PushConsumerBuilder setEnableFifoParallelConsuming(boolean enableFifoParallelProcessing);
Review Comment:
what about enableMessageGroupParallelConsume or enableParallelConsumeByMessageGroup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #984] Support fifo parallel consume in java pushconsumer [rocketmq-clients]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on code in PR #985:
URL: https://github.com/apache/rocketmq-clients/pull/985#discussion_r2055299172
##########
java/client-apis/src/main/java/org/apache/rocketmq/client/apis/consumer/PushConsumerBuilder.java:
##########
@@ -81,6 +81,14 @@ public interface PushConsumerBuilder {
*/
PushConsumerBuilder setConsumptionThreadCount(int count);
+ /**
+ * Set the fifo parallel processing.
+ *
+ * @param enableFifoParallelProcessing enable fifo parallel processing.
+ * @return the consumer builder instance.
+ */
+ PushConsumerBuilder setEnableFifoParallelConsuming(boolean enableFifoParallelProcessing);
Review Comment:
多了个空格，命名有点怪 fifo parallel ?
应该在接口上具体解释这个 feature 的行为
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #984] Support fifo parallel consume in java pushconsumer [rocketmq-clients]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on code in PR #985:
URL: https://github.com/apache/rocketmq-clients/pull/985#discussion_r2055299988
##########
java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/FifoConsumeService.java:
##########
@@ -35,16 +39,35 @@
@SuppressWarnings("UnstableApiUsage")
class FifoConsumeService extends ConsumeService {
private static final Logger log = LoggerFactory.getLogger(FifoConsumeService.class);
+ private final boolean enableFifoParallelConsuming;
Review Comment:
还应该在日志里标注，是否开启了这个 feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #984] Support fifo parallel consume in java pushconsumer [rocketmq-clients]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on code in PR #985:
URL: https://github.com/apache/rocketmq-clients/pull/985#discussion_r2055305311
##########
java/client-apis/src/main/java/org/apache/rocketmq/client/apis/consumer/PushConsumerBuilder.java:
##########
@@ -81,6 +81,14 @@ public interface PushConsumerBuilder {
*/
PushConsumerBuilder setConsumptionThreadCount(int count);
+ /**
+ * Set the fifo parallel processing.
+ *
+ * @param enableFifoParallelProcessing enable fifo parallel processing.
+ * @return the consumer builder instance.
+ */
+ PushConsumerBuilder setEnableFifoParallelConsuming(boolean enableFifoParallelProcessing);
Review Comment:
enableFifoConsumeAccelerator ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #984] Support fifo parallel consume in java pushconsumer [rocketmq-clients]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #985:
URL: https://github.com/apache/rocketmq-clients/pull/985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #984] Support fifo parallel consume in java pushconsumer [rocketmq-clients]
Posted by "dingshuangxi888 (via GitHub)" <gi...@apache.org>.
dingshuangxi888 commented on code in PR #985:
URL: https://github.com/apache/rocketmq-clients/pull/985#discussion_r2055334132
##########
java/client-apis/src/main/java/org/apache/rocketmq/client/apis/consumer/PushConsumerBuilder.java:
##########
@@ -81,6 +81,14 @@ public interface PushConsumerBuilder {
*/
PushConsumerBuilder setConsumptionThreadCount(int count);
+ /**
+ * Set the fifo parallel processing.
+ *
+ * @param enableFifoParallelProcessing enable fifo parallel processing.
+ * @return the consumer builder instance.
+ */
+ PushConsumerBuilder setEnableFifoParallelConsuming(boolean enableFifoParallelProcessing);
Review Comment:
what about enableMessageGroupParallelConsume ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #984] Support fifo parallel consume in java pushconsumer [rocketmq-clients]
Posted by "lollipopjin (via GitHub)" <gi...@apache.org>.
lollipopjin commented on code in PR #985:
URL: https://github.com/apache/rocketmq-clients/pull/985#discussion_r2055313984
##########
java/client-apis/src/main/java/org/apache/rocketmq/client/apis/consumer/PushConsumerBuilder.java:
##########
@@ -81,6 +81,14 @@ public interface PushConsumerBuilder {
*/
PushConsumerBuilder setConsumptionThreadCount(int count);
+ /**
+ * Set the fifo parallel processing.
+ *
+ * @param enableFifoParallelProcessing enable fifo parallel processing.
+ * @return the consumer builder instance.
+ */
+ PushConsumerBuilder setEnableFifoParallelConsuming(boolean enableFifoParallelProcessing);
Review Comment:
How about enableMessageGroupParallelism？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org