You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2015/01/19 11:36:42 UTC
[GitHub] couchdb-fauxton pull request: React building blocks and navbar
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/233
React building blocks and navbar
I've decided to break up #216 into two. This is the first one. It is the main react dependancies along with the main navigation bar done in React.js
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton react-navbar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #233
----
commit 94551274d33054060a1d9816ad7edfec2935d7e3
Author: Garren Smith <ga...@gmail.com>
Date: 2015-01-08T13:49:39Z
Add react dependencies
commit 96fe6506852f6bd59529433b6a953b0c9521630f
Author: Garren Smith <ga...@gmail.com>
Date: 2015-01-08T13:53:17Z
React building blocks
commit 269c36421bc55d20efac685508a74e5b0527805d
Author: Garren Smith <ga...@gmail.com>
Date: 2015-01-19T10:34:30Z
Add NavBar done in react
The navbar completly redone in react.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React building blocks and navbar
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70594028
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React building blocks and navbar
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70601632
Looks great. The only thing I spotted was on IE11, editing a View and clicking Save reloads the page but the Edit Index tab section has disappeared. But this is an existing bug that wasn't introduced here [N.B. ticket for it here: https://issues.apache.org/jira/browse/COUCHDB-2553].
+1 from me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React building blocks and navbar
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70482380
@robertkowalski I've fixed the './base' path and replaced " with '. I haven't added a separate commit for the whitespace this time as I want to reduce the number of commits in this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React building blocks and navbar
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70523920
+1
maybe @benkeen can take a final look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React building blocks and navbar
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React building blocks and navbar
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70617627
Thanks for reviewing. This is merged. Woo first React work in :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React building blocks and navbar
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React building blocks and navbar
Posted by garrensmith <gi...@git.apache.org>.
GitHub user garrensmith reopened a pull request:
https://github.com/apache/couchdb-fauxton/pull/233
React building blocks and navbar
I've decided to break up #216 into two. This is the first one. It is the main react dependancies along with the main navigation bar done in React.js
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton react-navbar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #233
----
commit 94551274d33054060a1d9816ad7edfec2935d7e3
Author: Garren Smith <ga...@gmail.com>
Date: 2015-01-08T13:49:39Z
Add react dependencies
commit 96fe6506852f6bd59529433b6a953b0c9521630f
Author: Garren Smith <ga...@gmail.com>
Date: 2015-01-08T13:53:17Z
React building blocks
commit 24a1b7a2010ea6f04216461e63e203e1560cb2d1
Author: Garren Smith <ga...@gmail.com>
Date: 2015-01-19T10:34:30Z
Add NavBar done in react
The navbar completly redone in react.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React building blocks and navbar
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70490948
@garrensmith, the travis run fails. can you fix the failing test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---