You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/27 11:49:52 UTC
[GitHub] [arrow] romainfrancois opened a new pull request #11240: [R] skip arrow_binary/arrow_large_binary class from R metadata
romainfrancois opened a new pull request #11240:
URL: https://github.com/apache/arrow/pull/11240
``` r
library(arrow, warn.conflicts = FALSE)
#> See arrow_info() for available features
raws <- charToRaw("bonjour")
RecordBatch$create(b = Array$create(list(raws), binary()))$metadata$r
#> NULL
RecordBatch$create(lb = Array$create(list(raws), large_binary()))$metadata$r
#> NULL
RecordBatch$create(fsb = Array$create(list(raws), fixed_size_binary(7L)))$metadata$r
#> NULL
```
<sup>Created on 2021-09-27 by the [reprex package](https://reprex.tidyverse.org) (v2.0.0)</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #11240: ARROW-14140: [R] skip arrow_binary/arrow_large_binary class from R metadata
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #11240:
URL: https://github.com/apache/arrow/pull/11240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11240: [R] skip arrow_binary/arrow_large_binary class from R metadata
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11240:
URL: https://github.com/apache/arrow/pull/11240#issuecomment-927796526
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11240: ARROW-14140: [R] skip arrow_binary/arrow_large_binary class from R metadata
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11240:
URL: https://github.com/apache/arrow/pull/11240#issuecomment-927797285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] romainfrancois commented on pull request #11240: ARROW-14140: [R] skip arrow_binary/arrow_large_binary class from R metadata
Posted by GitBox <gi...@apache.org>.
romainfrancois commented on pull request #11240:
URL: https://github.com/apache/arrow/pull/11240#issuecomment-928936730
Yes. This is similar to what we do for e.g. factors or int64 types, these classes (and the `byte_width` attribute) information is redundant with the information of the Array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #11240: ARROW-14140: [R] skip arrow_binary/arrow_large_binary class from R metadata
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #11240:
URL: https://github.com/apache/arrow/pull/11240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #11240: ARROW-14140: [R] skip arrow_binary/arrow_large_binary class from R metadata
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #11240:
URL: https://github.com/apache/arrow/pull/11240#issuecomment-928168893
This is because they're being set in the converter code and aren't needed in metadata$r?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #11240: ARROW-14140: [R] skip arrow_binary/arrow_large_binary class from R metadata
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #11240:
URL: https://github.com/apache/arrow/pull/11240#issuecomment-928168893
This is because they're being set in the converter code and aren't needed in metadata$r?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] romainfrancois commented on pull request #11240: ARROW-14140: [R] skip arrow_binary/arrow_large_binary class from R metadata
Posted by GitBox <gi...@apache.org>.
romainfrancois commented on pull request #11240:
URL: https://github.com/apache/arrow/pull/11240#issuecomment-928936730
Yes. This is similar to what we do for e.g. factors or int64 types, these classes (and the `byte_width` attribute) information is redundant with the information of the Array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org