You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Neilblaze (via GitHub)" <gi...@apache.org> on 2023/03/18 07:11:40 UTC
[GitHub] [apisix-dashboard] Neilblaze opened a new pull request, #2777: fix: locked input to a min of "0" of Retries
Neilblaze opened a new pull request, #2777:
URL: https://github.com/apache/apisix-dashboard/pull/2777
**Why submit this pull request?**
- [x] Bugfix
- [x] Improve performance ?
**What changes will this PR take into?**
In the Apisix dashboard, in the inputfield of `Retries` under [Services](https://apisix-dashboard.apiseven.com/service/create), we cannot set a negative value as of currently it doesn't supports it. Hence the up/down arrows have no function if the value is in the negative range.
RE: Primarily we can apply a `visibility: hidden` for `.ant-input-number-handler-wrap`, but I think the better way is to not remove those ` up/down ` arrows and instead, we can lock the input to a *minimum value of* **0**.
**Related issues**
resolves #2775
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
cc: @Baoyuantop, @freemankevin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2777: fix: locked input to a min of "0" for Retries
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #2777:
URL: https://github.com/apache/apisix-dashboard/pull/2777#issuecomment-1477124780
You can just commit your code directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2777: fix: locked input to a min of "0" for Retries
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2777:
URL: https://github.com/apache/apisix-dashboard/pull/2777#issuecomment-1474758204
## [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2777?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2777](https://codecov.io/gh/apache/apisix-dashboard/pull/2777?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f29350) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/4a2b50fff0a60e38224116b565a35828b197a8fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a2b50f) will **decrease** coverage by `6.05%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 0f29350 differs from pull request most recent head 50a524c. Consider uploading reports for the commit 50a524c to get more accurate results
```diff
@@ Coverage Diff @@
## master #2777 +/- ##
==========================================
- Coverage 74.02% 67.98% -6.05%
==========================================
Files 201 39 -162
Lines 7874 1040 -6834
Branches 886 268 -618
==========================================
- Hits 5829 707 -5122
+ Misses 1738 333 -1405
+ Partials 307 0 -307
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `67.98% <ø> (-8.84%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 178 files with indirect coverage changes](https://codecov.io/gh/apache/apisix-dashboard/pull/2777/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Neilblaze commented on pull request #2777: fix: locked input to a min of "0" for Retries
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on PR #2777:
URL: https://github.com/apache/apisix-dashboard/pull/2777#issuecomment-1476479194
@Baoyuantop Will this work or should I have to refactor it a little bit?
```js
it('should not allow negative values for retries', () => {
cy.visit('/routes/list');
cy.get('[name="Retries"]').type('-1').blur();
cy.contains('Retry times should not be less than 0');
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org