You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "link3280 (via GitHub)" <gi...@apache.org> on 2023/08/22 13:27:14 UTC
[GitHub] [kyuubi] link3280 opened a new pull request, #5190: [WIP] Explicit name Flink bootstrap SQL in application mode
link3280 opened a new pull request, #5190:
URL: https://github.com/apache/kyuubi/pull/5190
### _Why are the changes needed?_
Currently, the name of flink bootstrap SQL is auto-generated 'collect'.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
<!--
If a generative AI tooling has been used in the process of authoring this patch, please include
phrase 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #5190: [WIP] Explicit name Flink bootstrap SQL in application mode
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5190:
URL: https://github.com/apache/kyuubi/pull/5190#issuecomment-1690962598
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5190?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5190](https://app.codecov.io/gh/apache/kyuubi/pull/5190?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7814d9f) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/613297eae0b41f3526e0d126702e5cf4fcd05f62?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (613297e) will **not change** coverage.
> Report is 2 commits behind head on master.
> The diff coverage is `n/a`.
> :exclamation: Current head 7814d9f differs from pull request most recent head ac76929. Consider uploading reports for the commit ac76929 to get more accurate results
```diff
@@ Coverage Diff @@
## master #5190 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 565 566 +1
Lines 31641 31703 +62
Branches 4132 4134 +2
======================================
- Misses 31641 31703 +62
```
[see 5 files with indirect coverage changes](https://app.codecov.io/gh/apache/kyuubi/pull/5190/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] link3280 commented on pull request #5190: [FLINK] Explicitly name Flink bootstrap SQL in application mode
Posted by "link3280 (via GitHub)" <gi...@apache.org>.
link3280 commented on PR #5190:
URL: https://github.com/apache/kyuubi/pull/5190#issuecomment-1691150449
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] link3280 closed pull request #5190: [FLINK] Explicitly name Flink bootstrap SQL in application mode
Posted by "link3280 (via GitHub)" <gi...@apache.org>.
link3280 closed pull request #5190: [FLINK] Explicitly name Flink bootstrap SQL in application mode
URL: https://github.com/apache/kyuubi/pull/5190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org