You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/08 07:15:01 UTC
[GitHub] [druid] jihoonson opened a new pull request #10365: Inject ObjectMapper instead of manually setting it for TaskReportFileWriter
jihoonson opened a new pull request #10365:
URL: https://github.com/apache/druid/pull/10365
### Description
A simple cleanup around objectMapper injection for `TaskReportFileWriter`.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #10365: Inject ObjectMapper instead of manually setting it for TaskReportFileWriter
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #10365:
URL: https://github.com/apache/druid/pull/10365#issuecomment-688928324
@jihoonson what is the motivation behind this refactoring?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10365: Inject ObjectMapper instead of manually setting it for TaskReportFileWriter
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10365:
URL: https://github.com/apache/druid/pull/10365#issuecomment-727174805
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] closed pull request #10365: Inject ObjectMapper instead of manually setting it for TaskReportFileWriter
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #10365:
URL: https://github.com/apache/druid/pull/10365
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10365: Inject ObjectMapper instead of manually setting it for TaskReportFileWriter
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #10365:
URL: https://github.com/apache/druid/pull/10365#issuecomment-689304462
I will add unit tests for `MultipleFileTaskReportFileWriter` which the bot is complaining about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10365: Inject ObjectMapper instead of manually setting it for TaskReportFileWriter
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10365:
URL: https://github.com/apache/druid/pull/10365#issuecomment-751245248
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10365: Inject ObjectMapper instead of manually setting it for TaskReportFileWriter
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #10365:
URL: https://github.com/apache/druid/pull/10365#issuecomment-689141634
@abhishekagarwal87 the motivation is that the previous code was error-prone since you can forget to set objectMapper before using it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org