You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/05 07:50:56 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4081: Support
legacy time type in SegmentValidationAndRetentionConfig
codecov-io commented on issue #4081: Support legacy time type in SegmentValidationAndRetentionConfig
URL: https://github.com/apache/incubator-pinot/pull/4081#issuecomment-480182033
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4081?src=pr&el=h1) Report
> Merging [#4081](https://codecov.io/gh/apache/incubator-pinot/pull/4081?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/78bfe3e2dea4a8cdacf425fda416e1969378006b?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4081?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4081 +/- ##
============================================
+ Coverage 66.77% 66.84% +0.07%
Complexity 20 20
============================================
Files 1035 1035
Lines 51383 51372 -11
Branches 7193 7188 -5
============================================
+ Hits 34312 34342 +30
+ Misses 14711 14677 -34
+ Partials 2360 2353 -7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4081?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gment/name/NormalizedDateSegmentNameGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L25hbWUvTm9ybWFsaXplZERhdGVTZWdtZW50TmFtZUdlbmVyYXRvci5qYXZh) | `93.02% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/config/SegmentsValidationAndRetentionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1NlZ21lbnRzVmFsaWRhdGlvbkFuZFJldGVudGlvbkNvbmZpZy5qYXZh) | `48.23% <40%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ing/HelixExternalViewBasedTimeBoundaryService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkVGltZUJvdW5kYXJ5U2VydmljZS5qYXZh) | `77.27% <50%> (+15.6%)` | `0 <0> (ø)` | :arrow_down: |
| [...oller/api/resources/PinotTableRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90VGFibGVSZXN0bGV0UmVzb3VyY2UuamF2YQ==) | `49.05% <66.66%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/pinot/common/utils/time/TimeUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvdGltZS9UaW1lVXRpbHMuamF2YQ==) | `85.71% <84.61%> (+2.38%)` | `0 <0> (ø)` | :arrow_down: |
| [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `43.33% <0%> (-38.34%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `81.81% <0%> (-10.91%)` | `0% <0%> (ø)` | |
| [...a/org/apache/pinot/common/config/TagNameUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhZ05hbWVVdGlscy5qYXZh) | `69.23% <0%> (-5.13%)` | `0% <0%> (ø)` | |
| [...e/operator/dociditerators/BitmapDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9CaXRtYXBEb2NJZEl0ZXJhdG9yLmphdmE=) | `60.71% <0%> (-3.58%)` | `0% <0%> (ø)` | |
| [...inot/core/operator/docidsets/AndBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvQW5kQmxvY2tEb2NJZFNldC5qYXZh) | `55.55% <0%> (-2.09%)` | `0% <0%> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/incubator-pinot/pull/4081/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4081?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4081?src=pr&el=footer). Last update [78bfe3e...aafbf7c](https://codecov.io/gh/apache/incubator-pinot/pull/4081?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org