[jira] [Commented] (CXF-4771) [OAuth 2] MAC Authorization Header is not parsed correctly

["Sergey Beryozkin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-4771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559751#comment-13559751 ] 

Sergey Beryozkin commented on CXF-4771:
---------------------------------------

I'm finding that working with HTTP headers can be tricky :-). 
Consider:
{noformat}
Accept: text/xml,text/html
Authorization: MAC id="55aa32664c6e1ae9eea4f8d2a6b6fe3",nonce="bMIaTnH+yw7daK6augoW9waPBhQ="
{noformat}

what I'm actually not sure what HttpHeaders.getRequestHeader() should return (List of String) to make it right for both cases.
I guess it makes sense to split in the former case, in the latter case I decided to split to simplify parsing the actual value, but I wonder if it is right at all...
I'm going to introduce a property to regulate it better and also seek some clarifications at the JAX-RS list...
thanks

                
> [OAuth 2] MAC Authorization Header is not parsed correctly
> ----------------------------------------------------------
>
>                 Key: CXF-4771
>                 URL: https://issues.apache.org/jira/browse/CXF-4771
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS Security
>    Affects Versions: 2.7.2
>            Reporter: Craig McClanahan
>
> I'm trying to implement MAC authorization on my OAuth 2.0 server.  I use OAuthClientUtils#createAuthorizationHeader() to create an authorization header that, on the wire, looks something like this:
> Authorization:  MAC id="55aa32664c6e1ae9eea4f8d2a6b6fe3",nonce="bMIaTnH+yw7daK6augoW9waPBhQ=",mac="xMgBytGHEyVjLk0Bea5Sa6jfMdUvvrCWJhlL95rtNHs=",ts="1358796727285",
> There is a minor problem with this -- the trailing comma should be eliminated.
> The major problem, though, is when the server tries to parse this (AuthorizationUtils#getAuthorizationParts()).  The call to mc.getHttpHeaders().getRequestHeader("Authorization") returns five header values instead of one.  It appears to be parsing on both spaces and commas.  This causes the remaining logic to never parse the MAC token.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira