You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/11 04:00:43 UTC

[GitHub] [apisix] SkyeYoung commented on a change in pull request #6278: docs: improve consul_kv.md

SkyeYoung commented on a change in pull request #6278:
URL: https://github.com/apache/apisix/pull/6278#discussion_r804344573



##########
File path: docs/en/latest/discovery/consul_kv.md
##########
@@ -23,7 +23,7 @@ title: consul_kv
 
 ## Summary
 
-For users who used [nginx-upsync-module](https://github.com/weibocom/nginx-upsync-module) and consul key value for service discovery way, as we Weibo Mobile Team, maybe need it.
+For users that are using [nginx-upsync-module](https://github.com/weibocom/nginx-upsync-module) and Consul KV as a service discovery, like the Weibo Mobile Team, this may be required.

Review comment:
       @spacewander Sorry, in my opinion, "may be required" doesn't mean "enforce". If I change it to "this may be needed", do you think it will be better? Or do I change back?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org