You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "James Taylor (JIRA)" <ji...@apache.org> on 2014/07/25 22:28:38 UTC
[jira] [Commented] (PHOENIX-1111) Fix flapping unit tests by
removing inappropriate usage of TestUtil.TEST_PROPERTIES
[ https://issues.apache.org/jira/browse/PHOENIX-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074870#comment-14074870 ]
James Taylor commented on PHOENIX-1111:
---------------------------------------
+1. Thanks for tracking this down, [~samarthjain]. The idea of TestUtil.TEST_PROPERTIES is to capture any properties we want set by default for tests. It should be read-only. At some point, I had a read-only version of Properties that enforced this, but I can't find it. I think if we had TEST_PROPERTIES throw an exception if any put is done o the hash table, that would be a good guard against improper use.
> Fix flapping unit tests by removing inappropriate usage of TestUtil.TEST_PROPERTIES
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-1111
> URL: https://issues.apache.org/jira/browse/PHOENIX-1111
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.0.0, 5.0.0, 3.1
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Fix For: 5.0.0, 3.1, 4.1
>
> Attachments: PHOENIX-1111.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)