You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by al...@apache.org on 2017/04/26 10:07:24 UTC

[02/23] flink git commit: [FLINK-6107] Enable StaticVariableNameCheck in streaming checkstyle

[FLINK-6107] Enable StaticVariableNameCheck in streaming checkstyle


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/dceb9135
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/dceb9135
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/dceb9135

Branch: refs/heads/master
Commit: dceb9135ee030618e5f20e81f712420b812efc14
Parents: c190fd7
Author: Aljoscha Krettek <al...@gmail.com>
Authored: Sun Mar 19 15:30:23 2017 +0100
Committer: Aljoscha Krettek <al...@gmail.com>
Committed: Wed Apr 26 10:36:50 2017 +0200

----------------------------------------------------------------------
 .../api/windowing/windows/GlobalWindow.java     |  2 +-
 tools/maven/strict-checkstyle.xml               | 22 ++++++++++----------
 2 files changed, 12 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/dceb9135/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/GlobalWindow.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/GlobalWindow.java b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/GlobalWindow.java
index e1db976..b1e06f5 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/GlobalWindow.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/GlobalWindow.java
@@ -30,7 +30,7 @@ import org.apache.flink.core.memory.DataOutputView;
 @PublicEvolving
 public class GlobalWindow extends Window {
 
-	private static GlobalWindow INSTANCE = new GlobalWindow();
+	private static final GlobalWindow INSTANCE = new GlobalWindow();
 
 	private GlobalWindow() { }
 

http://git-wip-us.apache.org/repos/asf/flink/blob/dceb9135/tools/maven/strict-checkstyle.xml
----------------------------------------------------------------------
diff --git a/tools/maven/strict-checkstyle.xml b/tools/maven/strict-checkstyle.xml
index 2ce5644..459dc0b 100644
--- a/tools/maven/strict-checkstyle.xml
+++ b/tools/maven/strict-checkstyle.xml
@@ -315,17 +315,17 @@ This file is based on the checkstyle file of Apache Beam.
       <property name="severity" value="error"/>
     </module>
 
-    <!--<module name="StaticVariableNameCheck">-->
-      <!--&lt;!&ndash; Validates static, non-final fields against the supplied-->
-      <!--expression "^[a-z][a-zA-Z0-9]*_?$". &ndash;&gt;-->
-      <!--<metadata name="altname" value="StaticVariableName"/>-->
-      <!--<property name="applyToPublic" value="true"/>-->
-      <!--<property name="applyToProtected" value="true"/>-->
-      <!--<property name="applyToPackage" value="true"/>-->
-      <!--<property name="applyToPrivate" value="true"/>-->
-      <!--<property name="format" value="^[a-z][a-zA-Z0-9]*_?$"/>-->
-      <!--<property name="severity" value="error"/>-->
-    <!--</module>-->
+    <module name="StaticVariableNameCheck">
+      <!-- Validates static, non-final fields against the supplied
+      expression "^[a-z][a-zA-Z0-9]*_?$". -->
+      <metadata name="altname" value="StaticVariableName"/>
+      <property name="applyToPublic" value="true"/>
+      <property name="applyToProtected" value="true"/>
+      <property name="applyToPackage" value="true"/>
+      <property name="applyToPrivate" value="true"/>
+      <property name="format" value="^[a-z][a-zA-Z0-9]*_?$"/>
+      <property name="severity" value="error"/>
+    </module>
 
     <module name="MemberNameCheck">
       <!-- Validates non-static members against the supplied expression. -->