[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3677: Add `PhysicalPlan` enum to complement `ExecutionPlan` trait

[GitBox <gi...@apache.org>]

alamb commented on code in PR #3677:
URL: https://github.com/apache/arrow-datafusion/pull/3677#discussion_r985147289


##########
datafusion/core/src/physical_plan/mod.rs:
##########
@@ -42,6 +42,80 @@ use std::sync::Arc;
 use std::task::{Context, Poll};
 use std::{any::Any, pin::Pin};
 
+/// Enum representation of a physical plan
+pub enum PhysicalPlan {

Review Comment:
   😍 
   
   The only thing that is a little strange to me is that the compiler would allow `PhysicalPlan::Filter` to have something that wasn't actually a filter (aka it could be `HashJoinExec`)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org