You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "jimma (Created) (JIRA)" <ji...@apache.org> on 2012/03/15 07:58:17 UTC

[jira] [Created] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

AssertionBuilderFactory is created twice in PolicyBuilder initialization
------------------------------------------------------------------------

                 Key: NEETHI-14
                 URL: https://issues.apache.org/jira/browse/NEETHI-14
             Project: Neethi
          Issue Type: Improvement
    Affects Versions: 3.0.1
            Reporter: jimma
             Fix For: 3.0.2


This is kind of cosmetic fix to remove the line under PolicyBuilder().


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Updated] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

Posted by "jimma (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NEETHI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jimma updated NEETHI-14:
------------------------

    Description: 
Simply change the field factory to null can avoid this.


  was:
This is kind of cosmetic fix to remove the line under PolicyBuilder().


    
> AssertionBuilderFactory is created twice in PolicyBuilder initialization
> ------------------------------------------------------------------------
>
>                 Key: NEETHI-14
>                 URL: https://issues.apache.org/jira/browse/NEETHI-14
>             Project: Neethi
>          Issue Type: Improvement
>    Affects Versions: 3.0.1
>            Reporter: jimma
>             Fix For: 3.0.2
>
>         Attachments: NEETHI-14.patch
>
>
> Simply change the field factory to null can avoid this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Resolved] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

Posted by "Daniel Kulp (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NEETHI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved NEETHI-14.
-------------------------------

    Resolution: Fixed
      Assignee: Daniel Kulp

Patch applied.
                
> AssertionBuilderFactory is created twice in PolicyBuilder initialization
> ------------------------------------------------------------------------
>
>                 Key: NEETHI-14
>                 URL: https://issues.apache.org/jira/browse/NEETHI-14
>             Project: Neethi
>          Issue Type: Improvement
>    Affects Versions: 3.0.1
>            Reporter: jimma
>            Assignee: Daniel Kulp
>             Fix For: 3.0.2
>
>         Attachments: NEETHI-14.patch
>
>
> Simply change the field factory to null can avoid this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Commented] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NEETHI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230182#comment-13230182 ] 

Hudson commented on NEETHI-14:
------------------------------

Integrated in neethi-trunk #322 (See [https://builds.apache.org/job/neethi-trunk/322/])
    [NEETHI-14] Don't construct the AssertionBuilderFactory twice
Patch from Jim Ma applied. (Revision 1300970)

     Result = SUCCESS
dkulp : 
Files : 
* /webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/PolicyBuilder.java

                
> AssertionBuilderFactory is created twice in PolicyBuilder initialization
> ------------------------------------------------------------------------
>
>                 Key: NEETHI-14
>                 URL: https://issues.apache.org/jira/browse/NEETHI-14
>             Project: Neethi
>          Issue Type: Improvement
>    Affects Versions: 3.0.1
>            Reporter: jimma
>            Assignee: Daniel Kulp
>             Fix For: 3.0.2
>
>         Attachments: NEETHI-14.patch
>
>
> Simply change the field factory to null can avoid this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Updated] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

Posted by "jimma (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NEETHI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jimma updated NEETHI-14:
------------------------

    Attachment:     (was: NEETHI-14.patch)
    
> AssertionBuilderFactory is created twice in PolicyBuilder initialization
> ------------------------------------------------------------------------
>
>                 Key: NEETHI-14
>                 URL: https://issues.apache.org/jira/browse/NEETHI-14
>             Project: Neethi
>          Issue Type: Improvement
>    Affects Versions: 3.0.1
>            Reporter: jimma
>             Fix For: 3.0.2
>
>
> This is kind of cosmetic fix to remove the line under PolicyBuilder().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Issue Comment Edited] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

Posted by "Alessio Soldano (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NEETHI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230014#comment-13230014 ] 

Alessio Soldano edited comment on NEETHI-14 at 3/15/12 9:27 AM:
----------------------------------------------------------------

To add more explanation, this also solves a performance issue whenever using the constructor accepting a factory:

    public PolicyBuilder(AssertionBuilderFactory factory) {
        this.factory = factory;
    }

(the AssertionBuilderFactoryImpl creation involves creating an instance of ConverterRegistry too, which in turn uses reflection for registering converters)

Apache CXF, for instance, uses the constructor above.


                
      was (Author: asoldano):
    To add more explanation, this solves a performance issue whenever using the constructor accepting a factory:

    public PolicyBuilder(AssertionBuilderFactory factory) {
        this.factory = factory;
    }

(the AssertionBuilderFactoryImpl creation involves creating an instance of ConverterRegistry too, which in turn uses reflection for registering converters)

Apache CXF, for instance, uses the constructor above.


                  
> AssertionBuilderFactory is created twice in PolicyBuilder initialization
> ------------------------------------------------------------------------
>
>                 Key: NEETHI-14
>                 URL: https://issues.apache.org/jira/browse/NEETHI-14
>             Project: Neethi
>          Issue Type: Improvement
>    Affects Versions: 3.0.1
>            Reporter: jimma
>             Fix For: 3.0.2
>
>         Attachments: NEETHI-14.patch
>
>
> Simply change the field factory to null can avoid this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Updated] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

Posted by "jimma (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NEETHI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jimma updated NEETHI-14:
------------------------

    Attachment: NEETHI-14.patch
    
> AssertionBuilderFactory is created twice in PolicyBuilder initialization
> ------------------------------------------------------------------------
>
>                 Key: NEETHI-14
>                 URL: https://issues.apache.org/jira/browse/NEETHI-14
>             Project: Neethi
>          Issue Type: Improvement
>    Affects Versions: 3.0.1
>            Reporter: jimma
>             Fix For: 3.0.2
>
>         Attachments: NEETHI-14.patch
>
>
> This is kind of cosmetic fix to remove the line under PolicyBuilder().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Commented] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

Posted by "Alessio Soldano (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NEETHI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230014#comment-13230014 ] 

Alessio Soldano commented on NEETHI-14:
---------------------------------------

To add more explanation, this solves a performance issue whenever using the constructor accepting a factory:

    public PolicyBuilder(AssertionBuilderFactory factory) {
        this.factory = factory;
    }

(the AssertionBuilderFactoryImpl creation involves creating an instance of ConverterRegistry too, which in turn uses reflection for registering converters)

Apache CXF, for instance, uses the constructor above.


                
> AssertionBuilderFactory is created twice in PolicyBuilder initialization
> ------------------------------------------------------------------------
>
>                 Key: NEETHI-14
>                 URL: https://issues.apache.org/jira/browse/NEETHI-14
>             Project: Neethi
>          Issue Type: Improvement
>    Affects Versions: 3.0.1
>            Reporter: jimma
>             Fix For: 3.0.2
>
>         Attachments: NEETHI-14.patch
>
>
> Simply change the field factory to null can avoid this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Updated] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

Posted by "jimma (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NEETHI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jimma updated NEETHI-14:
------------------------

    Attachment:     (was: NEETHI-14.patch)
    
> AssertionBuilderFactory is created twice in PolicyBuilder initialization
> ------------------------------------------------------------------------
>
>                 Key: NEETHI-14
>                 URL: https://issues.apache.org/jira/browse/NEETHI-14
>             Project: Neethi
>          Issue Type: Improvement
>    Affects Versions: 3.0.1
>            Reporter: jimma
>             Fix For: 3.0.2
>
>         Attachments: NEETHI-14.patch
>
>
> Simply change the field factory to null can avoid this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Updated] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

Posted by "jimma (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NEETHI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jimma updated NEETHI-14:
------------------------

    Attachment: NEETHI-14.patch
    
> AssertionBuilderFactory is created twice in PolicyBuilder initialization
> ------------------------------------------------------------------------
>
>                 Key: NEETHI-14
>                 URL: https://issues.apache.org/jira/browse/NEETHI-14
>             Project: Neethi
>          Issue Type: Improvement
>    Affects Versions: 3.0.1
>            Reporter: jimma
>             Fix For: 3.0.2
>
>         Attachments: NEETHI-14.patch
>
>
> Simply change the field factory to null can avoid this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Updated] (NEETHI-14) AssertionBuilderFactory is created twice in PolicyBuilder initialization

Posted by "jimma (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NEETHI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jimma updated NEETHI-14:
------------------------

    Attachment: NEETHI-14.patch
    
> AssertionBuilderFactory is created twice in PolicyBuilder initialization
> ------------------------------------------------------------------------
>
>                 Key: NEETHI-14
>                 URL: https://issues.apache.org/jira/browse/NEETHI-14
>             Project: Neethi
>          Issue Type: Improvement
>    Affects Versions: 3.0.1
>            Reporter: jimma
>             Fix For: 3.0.2
>
>         Attachments: NEETHI-14.patch
>
>
> Simply change the field factory to null can avoid this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org