You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/05/01 14:42:50 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #4104: [ZEPPELIN-5338]. Add logging prefix in interpreter.sh for easy diagnose

zjffdu opened a new pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104


   ### What is this PR for?
   
   Currently, we have to change log4j.properties to get more output from script `interpreter.sh` in log4j output for diagnose. This PR is to add one trick: as long as the output is start with `[INFO]` in `interpreter.sh`, it will be redirected to log4j output.  
   
   ### What type of PR is it?
   [ Improvement ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5338
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4104: [ZEPPELIN-5338]. Add logging prefix in interpreter.sh for easy diagnose

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4104: [ZEPPELIN-5338]. Add logging prefix in interpreter.sh for easy diagnose

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104#issuecomment-849327345


   Will merge if no more comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4104: [ZEPPELIN-5338]. Add logging prefix in interpreter.sh for easy diagnose

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104#issuecomment-842768798


   @cuspymd Any more comment ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4104: [ZEPPELIN-5338]. Add logging prefix in interpreter.sh for easy diagnose

Posted by GitBox <gi...@apache.org>.
cuspymd commented on a change in pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104#discussion_r625012234



##########
File path: bin/interpreter.sh
##########
@@ -296,5 +296,6 @@ else
 fi
 
 # Don't remove this echo, it is for diagnose, this line of output will be redirected to java log4j output.
-echo "Interpreter launch command: ${INTERPRETER_RUN_COMMAND[@]}"
+# Output that starts with `[INFO]` will be redirected to log4j output.

Review comment:
       Isn't it better to express "log4j INFO output" or "log4j INFO message" more precisely than "log4j output"? Depending on the log level setting, debug messages can also be displayed in the output.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4104: [ZEPPELIN-5338]. Add logging prefix in interpreter.sh for easy diagnose

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104#discussion_r632894838



##########
File path: bin/interpreter.sh
##########
@@ -296,5 +296,6 @@ else
 fi
 
 # Don't remove this echo, it is for diagnose, this line of output will be redirected to java log4j output.
-echo "Interpreter launch command: ${INTERPRETER_RUN_COMMAND[@]}"
+# Output that starts with `[INFO]` will be redirected to log4j output.

Review comment:
       Thanks for the comment @cuspymd It is fixed now. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org