You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/07/06 22:53:26 UTC
[kudu-CR] [net util] fix reporting getaddrinfo() error
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7368
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
[net_util] fix reporting getaddrinfo() error
Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
---
M src/kudu/util/net/net_util.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/7368/1
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Edward Fancher, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7368
to look at the new patch set (#3).
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
[net_util] fix reporting getaddrinfo() error
An example of error output prior to this fix on Linux:
Network error: Unable to lookup FQDN: Success (error 0)
An example of error output after to this fix on Linux:
Network error: unable to look up canonical hostname for \
localhost 'mega.turbo': Name or service not known
Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
---
M src/kudu/util/net/net_util.cc
1 file changed, 45 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/7368/3
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
[net_util] fix reporting getaddrinfo() error
An example of error output:
on Linux, prior to this fix:
Network error: Unable to lookup FQDN: Success (error 0)
on Linux, after this fix:
Network error: unable to look up canonical hostname for \
localhost 'mega.turbo': Name or service not known
Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Reviewed-on: http://gerrit.cloudera.org:8080/7368
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/util/net/net_util.cc
1 file changed, 44 insertions(+), 31 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Edward Fancher (Code Review)" <ge...@cloudera.org>.
Edward Fancher has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7368/2/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
Line 313: gai_strerror(rc));
> small nit in mike's code: should probably save 'errno' to a local as soon a
Yeah, we should be careful about that. However if it turned out that Substitute() could set errno that would be pretty annoying!
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7368/2/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
Line 313: gai_strerror(rc));
> 1. Sounds good
Actually, that's only the man page which does not tell about EAI_SYSTEM -- the code actually works.
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
[net_util] fix reporting getaddrinfo() error
Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
---
M src/kudu/util/net/net_util.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/7368/2
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 2:
(3 comments)
> If it's not too difficult, could you add sample output before/after
> to the commit message?
Sure, I can add an example.
http://gerrit.cloudera.org:8080/#/c/7368/2/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
Line 312: Substitute("Unable to lookup canonical name for '$0'", *hostname),
> perhaps we should be specific here and say "canonical name for localhost '$
This sounds good -- will add.
Line 313: gai_strerror(rc));
> 1. For clarity, instead of "canonical name", can we say "canonical hostname
1. Sounds good
2. I did that first, but then I found it does not work on OS X . If we really want this to be present, then it will be if-defed then.
Line 313: gai_strerror(rc));
> small nit in mike's code: should probably save 'errno' to a local as soon a
That's the next thing I wanted to clean in this file -- delivering errno as returned from the libc calls.
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7368/2/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
Line 313: gai_strerror(rc));
> 1. For clarity, instead of "canonical name", can we say "canonical hostname
small nit in mike's code: should probably save 'errno' to a local as soon as possible after getting the bad result code (before calling Substitute) in case Substitute affects errno (I'm not sure if it does or not)
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Edward Fancher, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7368
to look at the new patch set (#4).
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
[net_util] fix reporting getaddrinfo() error
An example of error output:
on Linux, prior to this fix:
Network error: Unable to lookup FQDN: Success (error 0)
on Linux, after this fix:
Network error: unable to look up canonical hostname for \
localhost 'mega.turbo': Name or service not known
Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
---
M src/kudu/util/net/net_util.cc
1 file changed, 44 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/7368/4
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 2:
If it's not too difficult, could you add sample output before/after to the commit message?
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7368/2/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
Line 313: gai_strerror(rc));
1. For clarity, instead of "canonical name", can we say "canonical hostname"?
2. according to the man page, rc == EAI_SYSTEM requires checking errno:
EAI_SYSTEM
Other system error, check errno for details.
So this should probably be something like:
if (rc != 0) {
string msg = Substitute("Unable to lookup canonical hostname for '$0'", *hostname);
if (rc != EAI_SYSTEM) {
return Status::NetworkError(msg, gai_strerror(rc));
}
return Status::NetworkError(msg, ErrnoToString(errno), errno);
}
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7368/2/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
Line 313: gai_strerror(rc));
> Yeah, we should be careful about that. However if it turned out that Substi
Are you sure? See https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man3/gai_strerror.3.html#//apple_ref/doc/man/3/gai_strerror
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 4: Verified+1
Unrelated flake in client_samples-test -- I will take a look at that.
As it seen from here, the issued a request before the tablet server was registered with the master.
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [net util] fix reporting getaddrinfo() error
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [net_util] fix reporting getaddrinfo() error
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7368/2/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
Line 312: Substitute("Unable to lookup canonical name for '$0'", *hostname),
perhaps we should be specific here and say "canonical name for localhost '$0'" so that when we see the error it's more obviously regarding the configuration of the local machine and not looking up some other host?
--
To view, visit http://gerrit.cloudera.org:8080/7368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes