You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/04 17:00:02 UTC
[GitHub] [beam] reuvenlax opened a new pull request #11600: Allow accessing window parameters in finishBundle
reuvenlax opened a new pull request #11600:
URL: https://github.com/apache/beam/pull/11600
A bundle in Beam today can contain many windows. This often makes using finishBundle correctly tricky. Users are sometimes seen keeping maps in their DoFn of windows seen in a bundle so they can properly process them in finishBundle. We also don't support injecting an OutputReceiver in finishBundle, as there's no good way to associate a window to the output.
This PR allows injecting a BoundedWindow or OutputReceiver to the finishBundle function. In this case, the finishBundle will be invoked once per window seen in the bundle. If there is no such parameter, then the previous behavior of invoking finishBundle once is preserved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] commented on pull request #11600: Allow accessing window parameters in finishBundle
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #11600:
URL: https://github.com/apache/beam/pull/11600#issuecomment-653690991
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11600: Allow accessing window parameters in finishBundle
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11600:
URL: https://github.com/apache/beam/pull/11600#issuecomment-623732876
can you please create a JIRA?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] closed pull request #11600: Allow accessing window parameters in finishBundle
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #11600:
URL: https://github.com/apache/beam/pull/11600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] commented on pull request #11600: Allow accessing window parameters in finishBundle
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #11600:
URL: https://github.com/apache/beam/pull/11600#issuecomment-656961405
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org