Mirroring JIRA/GitHub comments

[Michael Mior <mm...@apache.org>]

This discussion came up a while back, but I think it would be really
helpful to have JIRA comments mirror to the association GitHub issue. When
reviewing PRs, I start by looking for those with no comments (indicating
someone else has already had a look). Then I have to dig up the JIRA case
and check if someone has reviewed there. If there are no objections, I'll
file a ticket with INFRA.

--
Michael Mior
mmior@apache.org

Re: Mirroring JIRA/GitHub comments

[Francis Chuang <fr...@apache.org>]

There is the possibility to turn off notification emails for comments, 
PR reviews and PR pushes: 
https://help.github.com/articles/choosing-the-delivery-method-for-your-notifications/#choosing-the-delivery-method-for-notifications-about-repository-activity

Unfortunately, the settings are on a global basis and it's not possible 
to turn them off for specific repositories.

On 5/12/2018 1:37 pm, Michael Mior wrote:
> If GH comments are mirrored to JIRA, it does mean that there would be
> duplicate emails if you're subscribed to both the PR on GH and the JIRA
> case. It does mean though that there would be one place where you could see
> all comments. Definitely this should only be enabled if the majority thinks
> it will be more productive. If it makes things worse, especially for those
> who invest much more time than I such as Julian, then I would revoke this
> suggestion.
>
> --
> Michael Mior
> mmior@apache.org
>
>
> Le mar. 4 déc. 2018 à 20:00, Julian Hyde <jh...@apache.org> a écrit :
>
>> I suspect that my practices are out of step with Michael's practices
>> (and maybe other people's too). I prefer to work in JIRA as much as
>> possible, using git's review mechanism only for critiques of
>> individual lines. I do this because I like being able to see how a
>> contribution evolved, and the reasoning behind it, long after that
>> contribution has been merged. Github is not very good at preserving
>> that stuff.
>>
>> Mirroring is all very well, but will it double the volume of email traffic?
>>
>> I'm feeling rather burned out because I committed over 50 of other
>> people's PRs last release.
>>
>> Julian
>>
>> On Tue, Dec 4, 2018 at 3:02 PM Francis Chuang <fr...@apache.org>
>> wrote:
>>> Thanks for taking this on, Michael!
>>>
>>> I think this is a good idea as having to go back and forth between a
>>> Github PR and JIRA issue can sometimes be a massive context switch. I
>>> think Github comments are current mirrored into the appropriate JIRA
>>> issue, but the reverse does not currently work.
>>>
>>> If possible, I think this would also be a good idea for the
>>> calcite-avatica and calcite-avatica-go repositories as well.
>>>
>>> On 5/12/2018 6:56 am, Michael Mior wrote:
>>>> This discussion came up a while back, but I think it would be really
>>>> helpful to have JIRA comments mirror to the association GitHub issue.
>> When
>>>> reviewing PRs, I start by looking for those with no comments
>> (indicating
>>>> someone else has already had a look). Then I have to dig up the JIRA
>> case
>>>> and check if someone has reviewed there. If there are no objections,
>> I'll
>>>> file a ticket with INFRA.
>>>>
>>>> --
>>>> Michael Mior
>>>> mmior@apache.org
>>>>

Re: Mirroring JIRA/GitHub comments

[Michael Mior <mm...@apache.org>]

If GH comments are mirrored to JIRA, it does mean that there would be
duplicate emails if you're subscribed to both the PR on GH and the JIRA
case. It does mean though that there would be one place where you could see
all comments. Definitely this should only be enabled if the majority thinks
it will be more productive. If it makes things worse, especially for those
who invest much more time than I such as Julian, then I would revoke this
suggestion.

--
Michael Mior
mmior@apache.org


Le mar. 4 déc. 2018 à 20:00, Julian Hyde <jh...@apache.org> a écrit :

> I suspect that my practices are out of step with Michael's practices
> (and maybe other people's too). I prefer to work in JIRA as much as
> possible, using git's review mechanism only for critiques of
> individual lines. I do this because I like being able to see how a
> contribution evolved, and the reasoning behind it, long after that
> contribution has been merged. Github is not very good at preserving
> that stuff.
>
> Mirroring is all very well, but will it double the volume of email traffic?
>
> I'm feeling rather burned out because I committed over 50 of other
> people's PRs last release.
>
> Julian
>
> On Tue, Dec 4, 2018 at 3:02 PM Francis Chuang <fr...@apache.org>
> wrote:
> >
> > Thanks for taking this on, Michael!
> >
> > I think this is a good idea as having to go back and forth between a
> > Github PR and JIRA issue can sometimes be a massive context switch. I
> > think Github comments are current mirrored into the appropriate JIRA
> > issue, but the reverse does not currently work.
> >
> > If possible, I think this would also be a good idea for the
> > calcite-avatica and calcite-avatica-go repositories as well.
> >
> > On 5/12/2018 6:56 am, Michael Mior wrote:
> > > This discussion came up a while back, but I think it would be really
> > > helpful to have JIRA comments mirror to the association GitHub issue.
> When
> > > reviewing PRs, I start by looking for those with no comments
> (indicating
> > > someone else has already had a look). Then I have to dig up the JIRA
> case
> > > and check if someone has reviewed there. If there are no objections,
> I'll
> > > file a ticket with INFRA.
> > >
> > > --
> > > Michael Mior
> > > mmior@apache.org
> > >
> >
>

Re: Mirroring JIRA/GitHub comments

[Julian Hyde <jh...@apache.org>]

I suspect that my practices are out of step with Michael's practices
(and maybe other people's too). I prefer to work in JIRA as much as
possible, using git's review mechanism only for critiques of
individual lines. I do this because I like being able to see how a
contribution evolved, and the reasoning behind it, long after that
contribution has been merged. Github is not very good at preserving
that stuff.

Mirroring is all very well, but will it double the volume of email traffic?

I'm feeling rather burned out because I committed over 50 of other
people's PRs last release.

Julian

On Tue, Dec 4, 2018 at 3:02 PM Francis Chuang <fr...@apache.org> wrote:
>
> Thanks for taking this on, Michael!
>
> I think this is a good idea as having to go back and forth between a
> Github PR and JIRA issue can sometimes be a massive context switch. I
> think Github comments are current mirrored into the appropriate JIRA
> issue, but the reverse does not currently work.
>
> If possible, I think this would also be a good idea for the
> calcite-avatica and calcite-avatica-go repositories as well.
>
> On 5/12/2018 6:56 am, Michael Mior wrote:
> > This discussion came up a while back, but I think it would be really
> > helpful to have JIRA comments mirror to the association GitHub issue. When
> > reviewing PRs, I start by looking for those with no comments (indicating
> > someone else has already had a look). Then I have to dig up the JIRA case
> > and check if someone has reviewed there. If there are no objections, I'll
> > file a ticket with INFRA.
> >
> > --
> > Michael Mior
> > mmior@apache.org
> >
>

Re: Mirroring JIRA/GitHub comments

[Francis Chuang <fr...@apache.org>]

Thanks for taking this on, Michael!

I think this is a good idea as having to go back and forth between a 
Github PR and JIRA issue can sometimes be a massive context switch. I 
think Github comments are current mirrored into the appropriate JIRA 
issue, but the reverse does not currently work.

If possible, I think this would also be a good idea for the 
calcite-avatica and calcite-avatica-go repositories as well.

On 5/12/2018 6:56 am, Michael Mior wrote:
> This discussion came up a while back, but I think it would be really
> helpful to have JIRA comments mirror to the association GitHub issue. When
> reviewing PRs, I start by looking for those with no comments (indicating
> someone else has already had a look). Then I have to dig up the JIRA case
> and check if someone has reviewed there. If there are no objections, I'll
> file a ticket with INFRA.
>
> --
> Michael Mior
> mmior@apache.org
>