You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2023/03/29 06:11:32 UTC

[GitHub] [arrow] AlenkaF commented on pull request #34765: GH-14917: [C++] Issues with GTest when building Arrow C++ on MacOS

AlenkaF commented on PR #34765:
URL: https://github.com/apache/arrow/pull/34765#issuecomment-1488001566

   Thank you for the thoughtful contribution @HaochengLIU !
   
   > Hi @AlenkaF , after some thoughts, IMO the correct thing here is to fix things at the building level rather than asking every Arrow user to add an extra flag manually in the doc. I have richful experience with CMake thus I go ahead and touch the toolchain file.
   
   That would for sure be useful for all that have this issue. My only thought here is that this doesn't seem to be an issue for every MacOS user. For this reason I suggested to first add this to the docs.
   
   The change in the PR looks good to me though (will still wait for the CI and local test to approve it).
   
   @kou what do you think about this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org