You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/09/05 01:52:29 UTC

[Bug 58331] New: [PATCH] Several Ptg updates: AreaPtg(String) is deprecated, replace ErrorConstants with FormulaError, remove hard-coded strings

https://bz.apache.org/bugzilla/show_bug.cgi?id=58331

            Bug ID: 58331
           Summary: [PATCH] Several Ptg updates: AreaPtg(String) is
                    deprecated, replace ErrorConstants with FormulaError,
                    remove hard-coded strings
           Product: POI
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: SS Common
          Assignee: dev@poi.apache.org
          Reporter: javenoneal@gmail.com

Created attachment 33063
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33063&action=edit
various changes to Ptg classes

>From bug 56328, AreaReference(String) has been deprecated. This makes
AreaPtg(String), Area3DPtg(String, externIdx), Area3DPxg(SheetIdentifier,
String), Area3DPxg(int, SheetIdentifier, String) deprecated constructors. I
have provided alternative constructors for all but Area3DPtg (I saw other
constructors with Ptg(int externIdx, String ref), so I didn't want to add
another constructor in case this gets refactored in the future to make the
parameter order consistent. Added test cases for new constructors.

Overhauled ErrPtg to replace the deprecated ErrorConstants (as of r1658185)
with FormulaError. org.apache.poi.ss.forumula.constant/ErrorConstant.java looks
like it duplicates the functionality of
org.apache.poi.ss.usermodel.ErrorConstants (deprecated) and
org.apache.poi.ss.usermodel.FormulaError. Some decision should be made to
consolidate these classes if only one is needed. My suggestion is to deprecate
org.apache.poi.ss.formula.constant.ErrorConstant so that only FormulaError
remains (FormulaError is an enum and has the highest quality and cquantity
conversion methods.

Moved several hard-coded strings in Ptg classes to static class variables.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58331] [PATCH] Several Ptg updates: AreaPtg(String) is deprecated, replace ErrorConstants with FormulaError, remove hard-coded strings

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58331

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58331] [PATCH] Several Ptg updates: AreaPtg(String) is deprecated, replace ErrorConstants with FormulaError, remove hard-coded strings

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58331

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org