You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Sébastien Col <se...@gmail.com> on 2017/01/06 16:32:48 UTC
Proposition for contribution
Hi,
I would like to contribute to the project and I thought I could start
working on the task #41118bb8 related to test suite enhancement and
migration to JUnit 4.
I found it from the helpwanted.apache.org site.
Is it still up-to-date?
Regards,
Sebastien
Re: Proposition for contribution
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 11.01.2017 um 09:44 schrieb S�bastien Col:
> 2017-01-11 7:38 GMT+01:00 Felix Schumacher <
> felix.schumacher@internetallee.de>:
>
>>
>> Am 10. Januar 2017 22:42:41 MEZ schrieb "S�bastien Col" <
>> sebastiencol@gmail.com>:
>>> Hi,
>>> I've been working tonight on unit testing
>>> org.apache.jmeter.core.report.
>>> I'm having troubles running the
>>> existing org.apache.jmeter.report.core.TestCsvSampleWriter with the
>>> following exception:
>>> java.lang.RuntimeException: Could not read JMeter properties
>>> file:jmeter.properties
>>> at
>>> org.apache.jmeter.util.JMeterUtils.loadJMeterProperties(
>> JMeterUtils.java:195)
>>> at
>>> org.apache.jmeter.report.core.TestCsvSampleWriter.
>> setUp(TestCsvSampleWriter.java:36)
>>> ...
>>>
>>> Anyone encountered this before?
>> How did you run the test? What is your setup?
>>
> I've setup sources using option 1 of the "Building JMeter" section of the
> documentation (the Ant task).
> Then I've imported the project in my Eclipse Neon. That's it.
>
> I have a JMETER_HOME set and I run the test from Eclipse (Run as -> JUnit
> Test).
Normally AllTests sets JMeterUtils JMeterHome. If you want to run the
tests in isolation, you will have to set it yourself like:
Index: test/src/org/apache/jmeter/report/core/TestCsvSampleWriter.java
===================================================================
--- test/src/org/apache/jmeter/report/core/TestCsvSampleWriter.java
(Revision 1779251)
+++ test/src/org/apache/jmeter/report/core/TestCsvSampleWriter.java
(Arbeitskopie)
@@ -33,7 +33,10 @@
@Before
public void setUp() throws Exception {
// We have to initialize JMeterUtils
- JMeterUtils.loadJMeterProperties("jmeter.properties");
+ if (JMeterUtils.getJMeterHome() == null) {
+ JMeterUtils.setJMeterHome(System.getenv("JMETER_HOME"));
+ }
+ JMeterUtils.loadJMeterProperties(JMeterUtils.getJMeterBinDir() +
"/jmeter.properties");
}
SampleMetadata metadata = new SampleMetadata(',', "a", "b");
(Which I will commit, if my tests run without failure).
Regards and sorry for the long delay.
Felix
> Thanks for your help.
> Sebastien
>
>
>> Felix
>>
>>> Thanks.
>>> Regards,
>>> Sebastien
>>>
>>> 2017-01-06 20:35 GMT+01:00 Philippe Mouawad
>>> <ph...@gmail.com>:
>>>
>>>> Hello,
>>>> Thanks for your proposal.
>>>> Yes it is still up to date.
>>>>
>>>> You can have a look at our Sonar report to know what needs testing:
>>>>
>>>> - https://builds.apache.org/analysis/
>>>>
>>>> Our priorities regarding tests:
>>>>
>>>> - JDBC protocol (more the NON Gui classes)
>>>> - HTTP (more non gui classes)
>>>> - org.apache.jmeter.assertions:
>>>> - .HTMLAssertion
>>>> - JSR223Assertion
>>>> - org.apache.jmeter.core.report
>>>> - org.apache.jmeter.visualizers.backend.graphite
>>>> - core/org/apache/jmeter/control
>>>>
>>>> Note coverage is not only related to JUnit tests but also to tests
>>> builds
>>>> with JMX plans and ran with Jacoco agent.
>>>>
>>>> Regards
>>>>
>>>>
>>>>
>>>> On Fri, Jan 6, 2017 at 5:32 PM, S�bastien Col
>>> <se...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>> I would like to contribute to the project and I thought I could
>>> start
>>>>> working on the task #41118bb8 related to test suite enhancement and
>>>>> migration to JUnit 4.
>>>>> I found it from the helpwanted.apache.org site.
>>>>> Is it still up-to-date?
>>>>> Regards,
>>>>> Sebastien
>>>>>
>>>>
>>>>
>>>> --
>>>> Cordialement.
>>>> Philippe Mouawad.
>>>>
Re: Proposition for contribution
Posted by Sébastien Col <se...@gmail.com>.
2017-01-11 7:38 GMT+01:00 Felix Schumacher <
felix.schumacher@internetallee.de>:
>
>
> Am 10. Januar 2017 22:42:41 MEZ schrieb "Sébastien Col" <
> sebastiencol@gmail.com>:
> >Hi,
> >I've been working tonight on unit testing
> >org.apache.jmeter.core.report.
> >I'm having troubles running the
> >existing org.apache.jmeter.report.core.TestCsvSampleWriter with the
> >following exception:
> >java.lang.RuntimeException: Could not read JMeter properties
> >file:jmeter.properties
> >at
> >org.apache.jmeter.util.JMeterUtils.loadJMeterProperties(
> JMeterUtils.java:195)
> >at
> >org.apache.jmeter.report.core.TestCsvSampleWriter.
> setUp(TestCsvSampleWriter.java:36)
> >...
> >
> >Anyone encountered this before?
>
> How did you run the test? What is your setup?
>
I've setup sources using option 1 of the "Building JMeter" section of the
documentation (the Ant task).
Then I've imported the project in my Eclipse Neon. That's it.
I have a JMETER_HOME set and I run the test from Eclipse (Run as -> JUnit
Test).
Thanks for your help.
Sebastien
>
> Felix
>
> >Thanks.
> >Regards,
> >Sebastien
> >
> >2017-01-06 20:35 GMT+01:00 Philippe Mouawad
> ><ph...@gmail.com>:
> >
> >> Hello,
> >> Thanks for your proposal.
> >> Yes it is still up to date.
> >>
> >> You can have a look at our Sonar report to know what needs testing:
> >>
> >> - https://builds.apache.org/analysis/
> >>
> >> Our priorities regarding tests:
> >>
> >> - JDBC protocol (more the NON Gui classes)
> >> - HTTP (more non gui classes)
> >> - org.apache.jmeter.assertions:
> >> - .HTMLAssertion
> >> - JSR223Assertion
> >> - org.apache.jmeter.core.report
> >> - org.apache.jmeter.visualizers.backend.graphite
> >> - core/org/apache/jmeter/control
> >>
> >> Note coverage is not only related to JUnit tests but also to tests
> >builds
> >> with JMX plans and ran with Jacoco agent.
> >>
> >> Regards
> >>
> >>
> >>
> >> On Fri, Jan 6, 2017 at 5:32 PM, Sébastien Col
> ><se...@gmail.com>
> >> wrote:
> >>
> >> > Hi,
> >> > I would like to contribute to the project and I thought I could
> >start
> >> > working on the task #41118bb8 related to test suite enhancement and
> >> > migration to JUnit 4.
> >> > I found it from the helpwanted.apache.org site.
> >> > Is it still up-to-date?
> >> > Regards,
> >> > Sebastien
> >> >
> >>
> >>
> >>
> >> --
> >> Cordialement.
> >> Philippe Mouawad.
> >>
>
Re: Proposition for contribution
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 10. Januar 2017 22:42:41 MEZ schrieb "Sébastien Col" <se...@gmail.com>:
>Hi,
>I've been working tonight on unit testing
>org.apache.jmeter.core.report.
>I'm having troubles running the
>existing org.apache.jmeter.report.core.TestCsvSampleWriter with the
>following exception:
>java.lang.RuntimeException: Could not read JMeter properties
>file:jmeter.properties
>at
>org.apache.jmeter.util.JMeterUtils.loadJMeterProperties(JMeterUtils.java:195)
>at
>org.apache.jmeter.report.core.TestCsvSampleWriter.setUp(TestCsvSampleWriter.java:36)
>...
>
>Anyone encountered this before?
How did you run the test? What is your setup?
Felix
>Thanks.
>Regards,
>Sebastien
>
>2017-01-06 20:35 GMT+01:00 Philippe Mouawad
><ph...@gmail.com>:
>
>> Hello,
>> Thanks for your proposal.
>> Yes it is still up to date.
>>
>> You can have a look at our Sonar report to know what needs testing:
>>
>> - https://builds.apache.org/analysis/
>>
>> Our priorities regarding tests:
>>
>> - JDBC protocol (more the NON Gui classes)
>> - HTTP (more non gui classes)
>> - org.apache.jmeter.assertions:
>> - .HTMLAssertion
>> - JSR223Assertion
>> - org.apache.jmeter.core.report
>> - org.apache.jmeter.visualizers.backend.graphite
>> - core/org/apache/jmeter/control
>>
>> Note coverage is not only related to JUnit tests but also to tests
>builds
>> with JMX plans and ran with Jacoco agent.
>>
>> Regards
>>
>>
>>
>> On Fri, Jan 6, 2017 at 5:32 PM, Sébastien Col
><se...@gmail.com>
>> wrote:
>>
>> > Hi,
>> > I would like to contribute to the project and I thought I could
>start
>> > working on the task #41118bb8 related to test suite enhancement and
>> > migration to JUnit 4.
>> > I found it from the helpwanted.apache.org site.
>> > Is it still up-to-date?
>> > Regards,
>> > Sebastien
>> >
>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
Re: Proposition for contribution
Posted by Sébastien Col <se...@gmail.com>.
Hi,
I've been working tonight on unit testing org.apache.jmeter.core.report.
I'm having troubles running the
existing org.apache.jmeter.report.core.TestCsvSampleWriter with the
following exception:
java.lang.RuntimeException: Could not read JMeter properties
file:jmeter.properties
at
org.apache.jmeter.util.JMeterUtils.loadJMeterProperties(JMeterUtils.java:195)
at
org.apache.jmeter.report.core.TestCsvSampleWriter.setUp(TestCsvSampleWriter.java:36)
...
Anyone encountered this before?
Thanks.
Regards,
Sebastien
2017-01-06 20:35 GMT+01:00 Philippe Mouawad <ph...@gmail.com>:
> Hello,
> Thanks for your proposal.
> Yes it is still up to date.
>
> You can have a look at our Sonar report to know what needs testing:
>
> - https://builds.apache.org/analysis/
>
> Our priorities regarding tests:
>
> - JDBC protocol (more the NON Gui classes)
> - HTTP (more non gui classes)
> - org.apache.jmeter.assertions:
> - .HTMLAssertion
> - JSR223Assertion
> - org.apache.jmeter.core.report
> - org.apache.jmeter.visualizers.backend.graphite
> - core/org/apache/jmeter/control
>
> Note coverage is not only related to JUnit tests but also to tests builds
> with JMX plans and ran with Jacoco agent.
>
> Regards
>
>
>
> On Fri, Jan 6, 2017 at 5:32 PM, Sébastien Col <se...@gmail.com>
> wrote:
>
> > Hi,
> > I would like to contribute to the project and I thought I could start
> > working on the task #41118bb8 related to test suite enhancement and
> > migration to JUnit 4.
> > I found it from the helpwanted.apache.org site.
> > Is it still up-to-date?
> > Regards,
> > Sebastien
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
Re: Proposition for contribution
Posted by Graham Russell <gr...@ham1.co.uk>.
As Philippe said I've started a test for the JDBCSampler and
AbstractJDBCTestElement using Spock:
https://github.com/ham1/jmeter/blob/spock/test/src/org/apache/jmeter/protocol/jdbc/sampler/JDBCSamplerSpec.groovy
but until we decide which Mocking/testing framework to use it would be
great to get some test coverage on the current trunk.
Thanks
Graham
On 16 February 2017 at 14:46, Philippe Mouawad
<ph...@gmail.com> wrote:
> Great !
> I think you can go ahead
> There was a discussion about a mocking framework to use.
> Graham started something around spock,
> Felix proposed jmockit, I don't know if he started something.
> And I mentioned mockito2 but without producing anything ;)
>
> But maybe your work does not need a mocking framework.
>
> Regards
>
> On Thursday, February 16, 2017, Woonsan Ko <woonsan@apache.org
> <javascript:_e(%7B%7D,'cvml','woonsan@apache.org');>> wrote:
>
>> Hi folks,
>>
>> Is there anyone working in unit tests for JDBC protocol?
>> If not, I'd like to take a look into it next week.
>>
>> Cheers,
>>
>> Woonsan
>>
>>
>> On Fri, Jan 6, 2017 at 2:35 PM, Philippe Mouawad
>> <ph...@gmail.com> wrote:
>> > Hello,
>> > Thanks for your proposal.
>> > Yes it is still up to date.
>> >
>> > You can have a look at our Sonar report to know what needs testing:
>> >
>> > - https://builds.apache.org/analysis/
>> >
>> > Our priorities regarding tests:
>> >
>> > - JDBC protocol (more the NON Gui classes)
>> > - HTTP (more non gui classes)
>> > - org.apache.jmeter.assertions:
>> > - .HTMLAssertion
>> > - JSR223Assertion
>> > - org.apache.jmeter.core.report
>> > - org.apache.jmeter.visualizers.backend.graphite
>> > - core/org/apache/jmeter/control
>> >
>> > Note coverage is not only related to JUnit tests but also to tests builds
>> > with JMX plans and ran with Jacoco agent.
>> >
>> > Regards
>> >
>> >
>> >
>> > On Fri, Jan 6, 2017 at 5:32 PM, Sébastien Col <se...@gmail.com>
>> > wrote:
>> >
>> >> Hi,
>> >> I would like to contribute to the project and I thought I could start
>> >> working on the task #41118bb8 related to test suite enhancement and
>> >> migration to JUnit 4.
>> >> I found it from the helpwanted.apache.org site.
>> >> Is it still up-to-date?
>> >> Regards,
>> >> Sebastien
>> >>
>> >
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
Proposition for contribution
Posted by Philippe Mouawad <ph...@gmail.com>.
Great !
I think you can go ahead
There was a discussion about a mocking framework to use.
Graham started something around spock,
Felix proposed jmockit, I don't know if he started something.
And I mentioned mockito2 but without producing anything ;)
But maybe your work does not need a mocking framework.
Regards
On Thursday, February 16, 2017, Woonsan Ko <woonsan@apache.org
<javascript:_e(%7B%7D,'cvml','woonsan@apache.org');>> wrote:
> Hi folks,
>
> Is there anyone working in unit tests for JDBC protocol?
> If not, I'd like to take a look into it next week.
>
> Cheers,
>
> Woonsan
>
>
> On Fri, Jan 6, 2017 at 2:35 PM, Philippe Mouawad
> <ph...@gmail.com> wrote:
> > Hello,
> > Thanks for your proposal.
> > Yes it is still up to date.
> >
> > You can have a look at our Sonar report to know what needs testing:
> >
> > - https://builds.apache.org/analysis/
> >
> > Our priorities regarding tests:
> >
> > - JDBC protocol (more the NON Gui classes)
> > - HTTP (more non gui classes)
> > - org.apache.jmeter.assertions:
> > - .HTMLAssertion
> > - JSR223Assertion
> > - org.apache.jmeter.core.report
> > - org.apache.jmeter.visualizers.backend.graphite
> > - core/org/apache/jmeter/control
> >
> > Note coverage is not only related to JUnit tests but also to tests builds
> > with JMX plans and ran with Jacoco agent.
> >
> > Regards
> >
> >
> >
> > On Fri, Jan 6, 2017 at 5:32 PM, Sébastien Col <se...@gmail.com>
> > wrote:
> >
> >> Hi,
> >> I would like to contribute to the project and I thought I could start
> >> working on the task #41118bb8 related to test suite enhancement and
> >> migration to JUnit 4.
> >> I found it from the helpwanted.apache.org site.
> >> Is it still up-to-date?
> >> Regards,
> >> Sebastien
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>
--
Cordialement.
Philippe Mouawad.
Re: Proposition for contribution
Posted by Woonsan Ko <wo...@apache.org>.
Hi folks,
Is there anyone working in unit tests for JDBC protocol?
If not, I'd like to take a look into it next week.
Cheers,
Woonsan
On Fri, Jan 6, 2017 at 2:35 PM, Philippe Mouawad
<ph...@gmail.com> wrote:
> Hello,
> Thanks for your proposal.
> Yes it is still up to date.
>
> You can have a look at our Sonar report to know what needs testing:
>
> - https://builds.apache.org/analysis/
>
> Our priorities regarding tests:
>
> - JDBC protocol (more the NON Gui classes)
> - HTTP (more non gui classes)
> - org.apache.jmeter.assertions:
> - .HTMLAssertion
> - JSR223Assertion
> - org.apache.jmeter.core.report
> - org.apache.jmeter.visualizers.backend.graphite
> - core/org/apache/jmeter/control
>
> Note coverage is not only related to JUnit tests but also to tests builds
> with JMX plans and ran with Jacoco agent.
>
> Regards
>
>
>
> On Fri, Jan 6, 2017 at 5:32 PM, Sébastien Col <se...@gmail.com>
> wrote:
>
>> Hi,
>> I would like to contribute to the project and I thought I could start
>> working on the task #41118bb8 related to test suite enhancement and
>> migration to JUnit 4.
>> I found it from the helpwanted.apache.org site.
>> Is it still up-to-date?
>> Regards,
>> Sebastien
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
Re: Proposition for contribution
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
Thanks for your proposal.
Yes it is still up to date.
You can have a look at our Sonar report to know what needs testing:
- https://builds.apache.org/analysis/
Our priorities regarding tests:
- JDBC protocol (more the NON Gui classes)
- HTTP (more non gui classes)
- org.apache.jmeter.assertions:
- .HTMLAssertion
- JSR223Assertion
- org.apache.jmeter.core.report
- org.apache.jmeter.visualizers.backend.graphite
- core/org/apache/jmeter/control
Note coverage is not only related to JUnit tests but also to tests builds
with JMX plans and ran with Jacoco agent.
Regards
On Fri, Jan 6, 2017 at 5:32 PM, Sébastien Col <se...@gmail.com>
wrote:
> Hi,
> I would like to contribute to the project and I thought I could start
> working on the task #41118bb8 related to test suite enhancement and
> migration to JUnit 4.
> I found it from the helpwanted.apache.org site.
> Is it still up-to-date?
> Regards,
> Sebastien
>
--
Cordialement.
Philippe Mouawad.