You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/09/28 18:49:07 UTC
[kudu-CR] build-and-test.sh: don't rebuild thirdparty
Hello Will Berkeley, Anonymous Coward #314,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11542
to review the following change.
Change subject: build-and-test.sh: don't rebuild thirdparty
......................................................................
build-and-test.sh: don't rebuild thirdparty
There's no reason NOT to pass NO_REBUILD_THIRDPARTY=1 to the Kudu cmake
invocation; we're guaranteed to have built the thirdparty tree just before.
Change-Id: Icba28146b44401499379d7c1f69742578456a448
---
M build-support/jenkins/build-and-test.sh
1 file changed, 11 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/11542/1
--
To view, visit http://gerrit.cloudera.org:8080/11542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icba28146b44401499379d7c1f69742578456a448
Gerrit-Change-Number: 11542
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #314
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] build-and-test.sh: don't rebuild thirdparty
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11542 )
Change subject: build-and-test.sh: don't rebuild thirdparty
......................................................................
build-and-test.sh: don't rebuild thirdparty
There's no reason NOT to pass NO_REBUILD_THIRDPARTY=1 to the Kudu cmake
invocation; we're guaranteed to have built the thirdparty tree just before.
Change-Id: Icba28146b44401499379d7c1f69742578456a448
Reviewed-on: http://gerrit.cloudera.org:8080/11542
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/jenkins/build-and-test.sh
1 file changed, 11 insertions(+), 3 deletions(-)
Approvals:
Hao Hao: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icba28146b44401499379d7c1f69742578456a448
Gerrit-Change-Number: 11542
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #314
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] build-and-test.sh: don't rebuild thirdparty
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11542 )
Change subject: build-and-test.sh: don't rebuild thirdparty
......................................................................
Patch Set 1:
(1 comment)
Thanks a lot for working on the fix, Adar!
http://gerrit.cloudera.org:8080/#/c/11542/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/11542/1/build-support/jenkins/build-and-test.sh@236
PS1, Line 236: CMAKE="
If I understand it correctly, when using clang, we will rebuild the thirdparty again?
--
To view, visit http://gerrit.cloudera.org:8080/11542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icba28146b44401499379d7c1f69742578456a448
Gerrit-Change-Number: 11542
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #314
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 19:27:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] build-and-test.sh: don't rebuild thirdparty
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11542 )
Change subject: build-and-test.sh: don't rebuild thirdparty
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11542/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/11542/1/build-support/jenkins/build-and-test.sh@236
PS1, Line 236: CMAKE="
> Right, that is what I thought. I was wondering because I didn't see NO_REBU
Ah yes, that was my mistake. It broke the build and I fixed it in PS2.
--
To view, visit http://gerrit.cloudera.org:8080/11542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icba28146b44401499379d7c1f69742578456a448
Gerrit-Change-Number: 11542
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #314
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:54:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] build-and-test.sh: don't rebuild thirdparty
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11542 )
Change subject: build-and-test.sh: don't rebuild thirdparty
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11542/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/11542/1/build-support/jenkins/build-and-test.sh@236
PS1, Line 236: CMAKE="
> No, clang is built as part of build-if-necessary.sh on L179. We should only
Right, that is what I thought. I was wondering because I didn't see NO_REBUILD_THIRDPARTY is set when building clang. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/11542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icba28146b44401499379d7c1f69742578456a448
Gerrit-Change-Number: 11542
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #314
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 22:02:45 +0000
Gerrit-HasComments: Yes
[kudu-CR] build-and-test.sh: don't rebuild thirdparty
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11542 )
Change subject: build-and-test.sh: don't rebuild thirdparty
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11542/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/11542/1/build-support/jenkins/build-and-test.sh@236
PS1, Line 236: CMAKE="
> If I understand it correctly, when using clang, we will rebuild the thirdpa
No, clang is built as part of build-if-necessary.sh on L179. We should only build thirdparty once in build-and-test.sh; this commit ensures that.
--
To view, visit http://gerrit.cloudera.org:8080/11542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icba28146b44401499379d7c1f69742578456a448
Gerrit-Change-Number: 11542
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #314
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 21:45:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] build-and-test.sh: don't rebuild thirdparty
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Anonymous Coward #314, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11542
to look at the new patch set (#2).
Change subject: build-and-test.sh: don't rebuild thirdparty
......................................................................
build-and-test.sh: don't rebuild thirdparty
There's no reason NOT to pass NO_REBUILD_THIRDPARTY=1 to the Kudu cmake
invocation; we're guaranteed to have built the thirdparty tree just before.
Change-Id: Icba28146b44401499379d7c1f69742578456a448
---
M build-support/jenkins/build-and-test.sh
1 file changed, 11 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/11542/2
--
To view, visit http://gerrit.cloudera.org:8080/11542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icba28146b44401499379d7c1f69742578456a448
Gerrit-Change-Number: 11542
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #314
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>