You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/02/14 21:20:27 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #34182: GH-34047: [C++][FlightRPC] Make DoAction warning less prominent
lidavidm opened a new pull request, #34182:
URL: https://github.com/apache/arrow/pull/34182
### Rationale for this change
The warning added for when you fail to consume a result stream (and get the final error/success result) is a bit aggressive. Ignore it in most cases.
### What changes are included in this PR?
Drop the warning to DEBUG level and don't log if it's just a cancellation.
### Are these changes tested?
Existing tests cover it.
### Are there any user-facing changes?
Users should see less inactionable warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34182: GH-34047: [C++][FlightRPC] Make DoAction warning less prominent
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34182:
URL: https://github.com/apache/arrow/pull/34182#issuecomment-1435492966
Benchmark runs are scheduled for baseline = 277bd3c76fddfda8704982c8d3d50188a460a168 and contender = ae1f98f57f4bf38e6e38231c8566e6cbaa98d8ac. ae1f98f57f4bf38e6e38231c8566e6cbaa98d8ac is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8fce183bdf634452a3dfa769ff9ef80d...8df438aa3ce04b208d51d64075bc60d0/)
[Failed :arrow_down:0.37% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5efe7c710b5a4f33b2175db5ec8be5cd...946eb94828ed4a29a9ebfdfdfcc93a7a/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/387e12bf9f93449e88b25fc30f09998b...2d0b039fe7b64c61be37a20ab29e912f/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/da18d63aa64b417899eee72211bf95a6...5a2617d53983425db28e9e1b595b10d6/)
Buildkite builds:
[Finished] [`ae1f98f5` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2396)
[Finished] [`ae1f98f5` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2426)
[Finished] [`ae1f98f5` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2394)
[Finished] [`ae1f98f5` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2418)
[Finished] [`277bd3c7` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2395)
[Failed] [`277bd3c7` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2425)
[Finished] [`277bd3c7` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2393)
[Finished] [`277bd3c7` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2417)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34182: GH-34047: [C++][FlightRPC] Make DoAction warning less prominent
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34182:
URL: https://github.com/apache/arrow/pull/34182#issuecomment-1430393987
* Closes: #34047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #34182: GH-34047: [C++][FlightRPC] Make DoAction warning less prominent
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #34182:
URL: https://github.com/apache/arrow/pull/34182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34182: GH-34047: [C++][FlightRPC] Make DoAction warning less prominent
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34182:
URL: https://github.com/apache/arrow/pull/34182#issuecomment-1430394027
:warning: GitHub issue #34047 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org