Found in Apache-Reload/Makefile.PL

[Torsten Förtsch <to...@gmx.net>]

Hi,

my $mp_gen;
if ($ENV{MOD_PERL_2_BUILD}) {
    push @ARGV, "-apxs $ENV{MP_APXS}";
    my $mp_gen = satisfy_mp_generation(2);
}
else {
    $mp_gen = satisfy_mp_generation();
}

The 2nd "my $mp_gen" inside the if-branch looks suspicious.

Further, what is the "push @ARGV" for? If it is needed do you really want to 
push the string "-apxs ..."? At shell level that would mean:

  perl Makefile.PL -apxs\ /usr/local/whatever/...

which is quite unusual (note the backslash quoting the blank).

Shouldn't it rather read

  push @ARGV, '-apxs', $ENV{MP_APXS};

or

  push @ARGV, "-apxs=$ENV{MP_APXS}";

Torsten Förtsch

-- 
Need professional modperl support? Hire me! (http://foertsch.name)

Like fantasy? http://kabatinte.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org