You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/27 06:25:34 UTC

[GitHub] [spark] Peng-Lei commented on a change in pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`

Peng-Lei commented on a change in pull request #33856:
URL: https://github.com/apache/spark/pull/33856#discussion_r697183289



##########
File path: core/src/main/scala/org/apache/spark/SparkException.scala
##########
@@ -90,7 +90,7 @@ private[spark] class SparkArithmeticException(errorClass: String, messageParamet
 /**
  * Class not found exception thrown from Spark with an error class.
  */
-class SparkClassNotFoundException(
+private[spark] class SparkClassNotFoundException(

Review comment:
       Instead of letting the user know about various kind of internal exception, Unified catch `Throwable` maybe simple?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org