You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/10/23 13:37:39 UTC
[GitHub] [sling-org-apache-sling-testing-clients] andreituicu opened a new pull request #19: In case the logintoken cookie is no longer valid, try obtaining a new one.
andreituicu opened a new pull request #19:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] dulvac edited a comment on pull request #19: In case the logintoken cookie is no longer valid, try obtaining a new one.
Posted by GitBox <gi...@apache.org>.
dulvac edited a comment on pull request #19:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/19#issuecomment-724629582
@andreituicu , I took your PR and modified it, since there were issues with implementing both `HttpRequestInterceptor` and `HttpResponseInterceptor` + refactored and added a test.
You can see it in https://github.com/apache/sling-org-apache-sling-testing-clients/commit/74246de8737de9fbefcddc255bb43d40aadde8ef . Are you ok with this? Can we close this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] dulvac commented on pull request #19: In case the logintoken cookie is no longer valid, try obtaining a new one.
Posted by GitBox <gi...@apache.org>.
dulvac commented on pull request #19:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/19#issuecomment-724629582
@andreituicu , I took your PR and modified it, since there were issues with implementing both `HttpRequestInterceptor` and `HttpResponseInterceptor` + refactored and added a test.
Are you ok with this? Can we close this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] andreituicu closed pull request #19: In case the logintoken cookie is no longer valid, try obtaining a new one.
Posted by GitBox <gi...@apache.org>.
andreituicu closed pull request #19:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] andreituicu commented on pull request #19: In case the logintoken cookie is no longer valid, try obtaining a new one.
Posted by GitBox <gi...@apache.org>.
andreituicu commented on pull request #19:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/19#issuecomment-724667371
sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org