You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/04/22 00:26:17 UTC

svn commit: r1470355 - /commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java

Author: sebb
Date: Sun Apr 21 22:26:17 2013
New Revision: 1470355

URL: http://svn.apache.org/r1470355
Log:
Document broken test

Modified:
    commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java

Modified: commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java
URL: http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java?rev=1470355&r1=1470354&r2=1470355&view=diff
==============================================================================
--- commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java (original)
+++ commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java Sun Apr 21 22:26:17 2013
@@ -347,6 +347,7 @@ public class CharSequenceInputStreamTest
         testSingleByteRead(TEST_STRING, "UTF-8");
     }
 
+    // This is broken for charsets that don't map each char to a byte
     public void testSkip(final String csName) throws Exception {
         final InputStream r = new CharSequenceInputStream("test", csName);
         try {
@@ -361,7 +362,7 @@ public class CharSequenceInputStreamTest
     }
 
     @Test
-    @Ignore
+    @Ignore // test is broken for charsets that generate multiple bytes per char.
     public void testSkip_RequiredCharsets() throws Exception {
         for (final String csName : getRequiredCharsetNames()) {
             testSkip(csName);