You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "vttranlina (via GitHub)" <gi...@apache.org> on 2023/11/29 10:58:39 UTC

[PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

vttranlina opened a new pull request, #1828:
URL: https://github.com/apache/james-project/pull/1828

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1413295228


##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMessageManager.java:
##########
@@ -0,0 +1,100 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one   *
+ * or more contributor license agreements.  See the NOTICE file *
+ * distributed with this work for additional information        *
+ * regarding copyright ownership.  The ASF licenses this file   *
+ * to you under the Apache License, Version 2.0 (the            *
+ * "License"); you may not use this file except in compliance   *
+ * with the License.  You may obtain a copy of the License at   *
+ *                                                              *
+ *   http://www.apache.org/licenses/LICENSE-2.0                 *
+ *                                                              *
+ * Unless required by applicable law or agreed to in writing,   *
+ * software distributed under the License is distributed on an  *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
+ * KIND, either express or implied.  See the License for the    *
+ * specific language governing permissions and limitations      *
+ * under the License.                                           *
+ ****************************************************************/
+
+package org.apache.james.mailbox.postgres.mail;
+
+import java.time.Clock;
+import java.util.EnumSet;
+
+import javax.mail.Flags;
+
+import org.apache.james.events.EventBus;
+import org.apache.james.mailbox.MailboxPathLocker;
+import org.apache.james.mailbox.MailboxSession;
+import org.apache.james.mailbox.exception.MailboxException;
+import org.apache.james.mailbox.model.Mailbox;
+import org.apache.james.mailbox.model.MailboxACL;
+import org.apache.james.mailbox.model.MessageId;
+import org.apache.james.mailbox.model.UidValidity;
+import org.apache.james.mailbox.quota.QuotaManager;
+import org.apache.james.mailbox.quota.QuotaRootResolver;
+import org.apache.james.mailbox.store.BatchSizes;
+import org.apache.james.mailbox.store.MailboxSessionMapperFactory;
+import org.apache.james.mailbox.store.MessageFactory;
+import org.apache.james.mailbox.store.MessageStorer;
+import org.apache.james.mailbox.store.PreDeletionHooks;
+import org.apache.james.mailbox.store.StoreMailboxManager;
+import org.apache.james.mailbox.store.StoreMessageManager;
+import org.apache.james.mailbox.store.StoreRightManager;
+import org.apache.james.mailbox.store.mail.MessageMapper;
+import org.apache.james.mailbox.store.mail.ThreadIdGuessingAlgorithm;
+import org.apache.james.mailbox.store.search.MessageSearchIndex;
+
+import com.github.fge.lambdas.Throwing;
+
+import reactor.core.publisher.Mono;
+
+public class PostgresMessageManager extends StoreMessageManager {
+
+    private final MailboxSessionMapperFactory mapperFactory;
+    private final StoreRightManager storeRightManager;
+    private final Mailbox mailbox;
+
+    public PostgresMessageManager(MailboxSessionMapperFactory mapperFactory,
+                                  MessageSearchIndex index, EventBus eventBus,
+                                  MailboxPathLocker locker, Mailbox mailbox,
+                                  QuotaManager quotaManager, QuotaRootResolver quotaRootResolver,
+                                  MessageId.Factory messageIdFactory, BatchSizes batchSizes,
+                                  StoreRightManager storeRightManager, ThreadIdGuessingAlgorithm threadIdGuessingAlgorithm,
+                                  Clock clock) {
+        super(StoreMailboxManager.DEFAULT_NO_MESSAGE_CAPABILITIES, mapperFactory, index, eventBus, locker, mailbox,
+            quotaManager, quotaRootResolver, batchSizes, storeRightManager, PreDeletionHooks.NO_PRE_DELETION_HOOK,
+            new MessageStorer.WithoutAttachment(mapperFactory, messageIdFactory, new MessageFactory.StoreMessageFactory(), threadIdGuessingAlgorithm, clock));
+        this.storeRightManager = storeRightManager;
+        this.mapperFactory = mapperFactory;
+        this.mailbox = mailbox;
+    }
+
+
+    @Override
+    public Flags getPermanentFlags(MailboxSession session) {
+        Flags flags = super.getPermanentFlags(session);
+        flags.add(Flags.Flag.USER);
+        return flags;
+    }
+
+    public Mono<MailboxMetaData> getMetaDataReactive(MailboxMetaData.RecentMode recentMode, MailboxSession mailboxSession, EnumSet<MailboxMetaData.Item> items) throws MailboxException {
+        MailboxACL resolvedAcl = getResolvedAcl(mailboxSession);
+        if (!storeRightManager.hasRight(mailbox, MailboxACL.Right.Read, mailboxSession)) {
+            return Mono.just(MailboxMetaData.sensibleInformationFree(resolvedAcl, getMailboxEntity().getUidValidity(), isWriteable(mailboxSession)));
+        }
+        Flags permanentFlags = getPermanentFlags(mailboxSession);
+        UidValidity uidValidity = getMailboxEntity().getUidValidity();
+        MessageMapper messageMapper = mapperFactory.getMessageMapper(mailboxSession);
+
+        return messageMapper.executeReactive(
+            nextUid(messageMapper, items)
+                .flatMap(nextUid -> highestModSeq(messageMapper, items)

Review Comment:
   Will do it in another task https://github.com/linagora/james-project/issues/4945 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1413428855


##########
mailbox/postgres/src/test/java/org/apache/james/mailbox/postgres/PostgresMailboxManagerTest.java:
##########
@@ -20,66 +20,50 @@
 
 import java.util.Optional;
 
-import org.apache.james.backends.jpa.JpaTestCluster;
 import org.apache.james.backends.postgres.PostgresExtension;
 import org.apache.james.events.EventBus;
 import org.apache.james.mailbox.MailboxManagerTest;
 import org.apache.james.mailbox.SubscriptionManager;
-import org.apache.james.mailbox.postgres.openjpa.OpenJPAMailboxManager;
+import org.apache.james.mailbox.postgres.mail.PostgresMailboxManager;
 import org.apache.james.mailbox.store.StoreSubscriptionManager;
-import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Nested;
-import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
-class JPAMailboxManagerTest extends MailboxManagerTest<OpenJPAMailboxManager> {
+class PostgresMailboxManagerTest extends MailboxManagerTest<PostgresMailboxManager> {
 
     @Disabled("JPAMailboxManager is using DefaultMessageId which doesn't support full feature of a messageId, which is an essential" +
         " element of the Vault")
     @Nested
     class HookTests {

Review Comment:
   TODO: plan to re-enable this...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1413427582


##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMailboxManager.java:
##########
@@ -42,36 +42,35 @@
 import org.apache.james.mailbox.store.quota.QuotaComponents;
 import org.apache.james.mailbox.store.search.MessageSearchIndex;
 
-/**
- * OpenJPA implementation of MailboxManager
- */
-public class OpenJPAMailboxManager extends StoreMailboxManager {
-    public static final EnumSet<MailboxCapabilities> MAILBOX_CAPABILITIES = EnumSet.of(MailboxCapabilities.UserFlag,
+public class PostgresMailboxManager extends StoreMailboxManager {
+
+    public static final EnumSet<MailboxCapabilities> MAILBOX_CAPABILITIES = EnumSet.of(
+        MailboxCapabilities.UserFlag,

Review Comment:
   I think we can claim ACL support in here...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1411929995


##########
mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java:
##########
@@ -1666,6 +1667,7 @@ void getMetaDataShouldReturnDefaultValueWhenNoReadRight() throws Exception {
     @Nested
     public class BasicFeaturesTests {
 
+        @Disabled
         @Test
         void renameMailboxShouldReturnAllRenamedResultsIncludeChildren() throws MailboxException {

Review Comment:
   I think I did get it...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1828:
URL: https://github.com/apache/james-project/pull/1828#issuecomment-1831694487

   +1 one for a PR on PostgresMailboxSessionMapperFactory first


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1828:
URL: https://github.com/apache/james-project/pull/1828#issuecomment-1835878705

   @vttranlina I let you rebase?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1410473500


##########
mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java:
##########
@@ -1666,6 +1667,7 @@ void getMetaDataShouldReturnDefaultValueWhenNoReadRight() throws Exception {
     @Nested
     public class BasicFeaturesTests {
 
+        @Disabled
         @Test
         void renameMailboxShouldReturnAllRenamedResultsIncludeChildren() throws MailboxException {

Review Comment:
   > Somebody can help me debug it?
   
   Sorry, I did not succeed in debugging the hanging test, at least until now.
   My feeling is that the hanging could be because of blocking code execution on the Postgres r2dbc driver thread.
   Even try `subscribeOn` or `publishOn` boundedElastic (with Mono.defer...), the whole code still executes on the Postgres r2dbc driver thread.
   ```java
   executed sql query on thread reactor-tcp-epoll-1
   executed sql query on thread reactor-tcp-epoll-1
   executed sql query on thread reactor-tcp-epoll-1
   executed sql query on thread reactor-tcp-epoll-1
   executed sql query on thread reactor-tcp-epoll-1
   executed sql query on thread reactor-tcp-epoll-1
   ```
   
   With Cassandra we can manipulate blocking code on other blocking threads, but somehow we can not change the thread of the source (r2dbc-postgresql uses reactor netty event loop). That leads to some blocking code inevitably executing on the Postgres driver thread.
   
   I captured a thread dump while the test hanged, but I could not spot anything wrong so far:
   [jstack.txt](https://github.com/apache/james-project/files/13511570/jstack.txt)
   
   Other expertise on Reactor would help indeed.
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1409114397


##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMessageManager.java:
##########
@@ -0,0 +1,100 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one   *
+ * or more contributor license agreements.  See the NOTICE file *
+ * distributed with this work for additional information        *
+ * regarding copyright ownership.  The ASF licenses this file   *
+ * to you under the Apache License, Version 2.0 (the            *
+ * "License"); you may not use this file except in compliance   *
+ * with the License.  You may obtain a copy of the License at   *
+ *                                                              *
+ *   http://www.apache.org/licenses/LICENSE-2.0                 *
+ *                                                              *
+ * Unless required by applicable law or agreed to in writing,   *
+ * software distributed under the License is distributed on an  *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
+ * KIND, either express or implied.  See the License for the    *
+ * specific language governing permissions and limitations      *
+ * under the License.                                           *
+ ****************************************************************/
+
+package org.apache.james.mailbox.postgres.mail;
+
+import java.time.Clock;
+import java.util.EnumSet;
+
+import javax.mail.Flags;
+
+import org.apache.james.events.EventBus;
+import org.apache.james.mailbox.MailboxPathLocker;
+import org.apache.james.mailbox.MailboxSession;
+import org.apache.james.mailbox.exception.MailboxException;
+import org.apache.james.mailbox.model.Mailbox;
+import org.apache.james.mailbox.model.MailboxACL;
+import org.apache.james.mailbox.model.MessageId;
+import org.apache.james.mailbox.model.UidValidity;
+import org.apache.james.mailbox.quota.QuotaManager;
+import org.apache.james.mailbox.quota.QuotaRootResolver;
+import org.apache.james.mailbox.store.BatchSizes;
+import org.apache.james.mailbox.store.MailboxSessionMapperFactory;
+import org.apache.james.mailbox.store.MessageFactory;
+import org.apache.james.mailbox.store.MessageStorer;
+import org.apache.james.mailbox.store.PreDeletionHooks;
+import org.apache.james.mailbox.store.StoreMailboxManager;
+import org.apache.james.mailbox.store.StoreMessageManager;
+import org.apache.james.mailbox.store.StoreRightManager;
+import org.apache.james.mailbox.store.mail.MessageMapper;
+import org.apache.james.mailbox.store.mail.ThreadIdGuessingAlgorithm;
+import org.apache.james.mailbox.store.search.MessageSearchIndex;
+
+import com.github.fge.lambdas.Throwing;
+
+import reactor.core.publisher.Mono;
+
+public class PostgresMessageManager extends StoreMessageManager {
+
+    private final MailboxSessionMapperFactory mapperFactory;
+    private final StoreRightManager storeRightManager;
+    private final Mailbox mailbox;
+
+    public PostgresMessageManager(MailboxSessionMapperFactory mapperFactory,
+                                  MessageSearchIndex index, EventBus eventBus,
+                                  MailboxPathLocker locker, Mailbox mailbox,
+                                  QuotaManager quotaManager, QuotaRootResolver quotaRootResolver,
+                                  MessageId.Factory messageIdFactory, BatchSizes batchSizes,
+                                  StoreRightManager storeRightManager, ThreadIdGuessingAlgorithm threadIdGuessingAlgorithm,
+                                  Clock clock) {
+        super(StoreMailboxManager.DEFAULT_NO_MESSAGE_CAPABILITIES, mapperFactory, index, eventBus, locker, mailbox,
+            quotaManager, quotaRootResolver, batchSizes, storeRightManager, PreDeletionHooks.NO_PRE_DELETION_HOOK,
+            new MessageStorer.WithoutAttachment(mapperFactory, messageIdFactory, new MessageFactory.StoreMessageFactory(), threadIdGuessingAlgorithm, clock));
+        this.storeRightManager = storeRightManager;
+        this.mapperFactory = mapperFactory;
+        this.mailbox = mailbox;
+    }
+
+
+    @Override
+    public Flags getPermanentFlags(MailboxSession session) {
+        Flags flags = super.getPermanentFlags(session);
+        flags.add(Flags.Flag.USER);
+        return flags;
+    }
+
+    public Mono<MailboxMetaData> getMetaDataReactive(MailboxMetaData.RecentMode recentMode, MailboxSession mailboxSession, EnumSet<MailboxMetaData.Item> items) throws MailboxException {
+        MailboxACL resolvedAcl = getResolvedAcl(mailboxSession);
+        if (!storeRightManager.hasRight(mailbox, MailboxACL.Right.Read, mailboxSession)) {
+            return Mono.just(MailboxMetaData.sensibleInformationFree(resolvedAcl, getMailboxEntity().getUidValidity(), isWriteable(mailboxSession)));
+        }
+        Flags permanentFlags = getPermanentFlags(mailboxSession);
+        UidValidity uidValidity = getMailboxEntity().getUidValidity();
+        MessageMapper messageMapper = mapperFactory.getMessageMapper(mailboxSession);
+
+        return messageMapper.executeReactive(
+            nextUid(messageMapper, items)
+                .flatMap(nextUid -> highestModSeq(messageMapper, items)

Review Comment:
   - [ ] todo optimize by single query to the database 



##########
mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java:
##########
@@ -1666,6 +1667,7 @@ void getMetaDataShouldReturnDefaultValueWhenNoReadRight() throws Exception {
     @Nested
     public class BasicFeaturesTests {
 
+        @Disabled
         @Test
         void renameMailboxShouldReturnAllRenamedResultsIncludeChildren() throws MailboxException {

Review Comment:
   I don't know why `rename` method is hanging for this test case. (hanging, not throw exception)(org.apache.james.mailbox.store.StoreMailboxManager#doRenameMailbox)
   
   Some test `rename` work, and some test `rename` hanging. 
   I thought about `MailboxPathLocker`, and I tried to `NoMailboxPathLocker` as a monkey doing. But it did not work. 
   
   Somebody can help me debug it?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1409121102


##########
mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java:
##########
@@ -1666,6 +1667,7 @@ void getMetaDataShouldReturnDefaultValueWhenNoReadRight() throws Exception {
     @Nested
     public class BasicFeaturesTests {
 
+        @Disabled
         @Test
         void renameMailboxShouldReturnAllRenamedResultsIncludeChildren() throws MailboxException {

Review Comment:
   I don't know why `rename` method is hanging for this test case. (hanging, not throw exception)(org.apache.james.mailbox.store.StoreMailboxManager#doRenameMailbox)
   
   Some test `rename` work, and some test `rename` hanging. 
   I thought about `MailboxPathLocker`, and I tried to `NoMailboxPathLocker` as a monkey doing. But it did not work. 
   (I can't catch exactly which line makes hanging)
   
   Somebody can help me debug it?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1411824671


##########
mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java:
##########
@@ -1666,6 +1667,7 @@ void getMetaDataShouldReturnDefaultValueWhenNoReadRight() throws Exception {
     @Nested
     public class BasicFeaturesTests {
 
+        @Disabled
         @Test
         void renameMailboxShouldReturnAllRenamedResultsIncludeChildren() throws MailboxException {

Review Comment:
   Well, main thread await the reactor operation.  Nothing else is currently done by the JVM.
   
   I more suspect a deadlock on PG side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1413319119


##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/quota/PostgresCurrentQuotaManager.java:
##########
@@ -40,6 +42,8 @@ public class PostgresCurrentQuotaManager implements CurrentQuotaManager {
 
     private final PostgresQuotaCurrentValueDAO currentValueDao;
 
+    @Inject
+

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #1828:
URL: https://github.com/apache/james-project/pull/1828


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1409127427


##########
mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java:
##########
@@ -1666,6 +1667,7 @@ void getMetaDataShouldReturnDefaultValueWhenNoReadRight() throws Exception {
     @Nested
     public class BasicFeaturesTests {
 
+        @Disabled
         @Test
         void renameMailboxShouldReturnAllRenamedResultsIncludeChildren() throws MailboxException {

Review Comment:
   the test case was marked ` @Disabled` is the hanging test
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1828:
URL: https://github.com/apache/james-project/pull/1828#issuecomment-1833117627

   > +1 one for a PR on PostgresMailboxSessionMapperFactory first
   
   https://github.com/apache/james-project/pull/1829


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [WIP] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #1828:
URL: https://github.com/apache/james-project/pull/1828#discussion_r1413014830


##########
mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java:
##########
@@ -1666,6 +1667,7 @@ void getMetaDataShouldReturnDefaultValueWhenNoReadRight() throws Exception {
     @Nested
     public class BasicFeaturesTests {
 
+        @Disabled
         @Test
         void renameMailboxShouldReturnAllRenamedResultsIncludeChildren() throws MailboxException {

Review Comment:
   Can you explain what happened?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-2586 Guide binding Postgres Message/Mailbox mapper [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1828:
URL: https://github.com/apache/james-project/pull/1828#issuecomment-1838071681

   Rebase please :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org