You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2014/08/08 11:03:30 UTC
svn commit: r1616696 - /subversion/branches/1.8.x/STATUS
Author: stefan2
Date: Fri Aug 8 09:03:29 2014
New Revision: 1616696
URL: http://svn.apache.org/r1616696
Log:
* 1.8.x/STATUS:
Add r1615354 to r1611379 group and unveto the latter.
Modified:
subversion/branches/1.8.x/STATUS
Modified: subversion/branches/1.8.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.8.x/STATUS?rev=1616696&r1=1616695&r2=1616696&view=diff
==============================================================================
--- subversion/branches/1.8.x/STATUS (original)
+++ subversion/branches/1.8.x/STATUS Fri Aug 8 09:03:29 2014
@@ -133,6 +133,22 @@ Candidate changes:
Votes:
+1: breser, philip
+ * r1611379, r1612405, r1615354
+ Fix revprop caching initialization delays for ra_serf on Windows.
+ Justification:
+ Without this patch, even small checkouts may take 20 to 40
+ seconds longer. This patch switches the named atomics SHM
+ initialization guard to the same "never delete the lock file"
+ pattern that we use for FSFS-internal locks.
+ Notes:
+ Branch is needed since SVN_VA_NULL is not available in 1.8.x.
+ Same goes for svn_io_file_create_empty.
+ Branch:
+ ^/subversion/branches/1.8.x-r1611379
+ Votes:
+ +1: stefan2
+ +1 (without r1615354): brane, breser
+
* r1612225
Ignore ENOTIMPL and EINCOMPLETE errors when tweaking temporary file
permission bits on non-windows systems.
@@ -169,22 +185,5 @@ Veto-blocked changes:
the root cause is not fixed. Discussion:
http://svn.haxx.se/dev/archive-2014-01/0158.shtml)
- * r1611379, r1612405
- Fix revprop caching initialization delays for ra_serf on Windows.
- Justification:
- Without this patch, even small checkouts may take 20 to 40
- seconds longer. This patch switches the named atomics SHM
- initialization guard to the same "never delete the lock file"
- pattern that we use for FSFS-internal locks.
- Notes:
- Branch is needed since SVN_VA_NULL is not available in 1.8.x.
- Same goes for svn_io_file_create_empty.
- Branch:
- ^/subversion/branches/1.8.x-r1611379
- Votes:
- +1: stefan2, brane, breser
- -1: ivan (Race condition and undefined behavior. See:
- http://svn.haxx.se/dev/archive-2014-08/0007.shtml)
-
Approved changes:
=================
Re: svn commit: r1616696 - /subversion/branches/1.8.x/STATUS
Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Fri, Aug 8, 2014 at 11:41 AM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On 8 August 2014 13:03, <st...@apache.org> wrote:
> > Author: stefan2
> > Date: Fri Aug 8 09:03:29 2014
> > New Revision: 1616696
> >
> > URL: http://svn.apache.org/r1616696
> > Log:
> > * 1.8.x/STATUS:
> > Add r1615354 to r1611379 group and unveto the latter.
> >
> > Modified:
> > subversion/branches/1.8.x/STATUS
> >
> > Modified: subversion/branches/1.8.x/STATUS
> > URL:
> http://svn.apache.org/viewvc/subversion/branches/1.8.x/STATUS?rev=1616696&r1=1616695&r2=1616696&view=diff
> >
> ==============================================================================
> > --- subversion/branches/1.8.x/STATUS (original)
> > +++ subversion/branches/1.8.x/STATUS Fri Aug 8 09:03:29 2014
> > @@ -133,6 +133,22 @@ Candidate changes:
> > Votes:
> > +1: breser, philip
> >
> > + * r1611379, r1612405, r1615354
> > + Fix revprop caching initialization delays for ra_serf on Windows.
> > + Justification:
> > + Without this patch, even small checkouts may take 20 to 40
> > + seconds longer. This patch switches the named atomics SHM
> > + initialization guard to the same "never delete the lock file"
> > + pattern that we use for FSFS-internal locks.
> > + Notes:
> > + Branch is needed since SVN_VA_NULL is not available in 1.8.x.
> > + Same goes for svn_io_file_create_empty.
> > + Branch:
> > + ^/subversion/branches/1.8.x-r1611379
> > + Votes:
> > + +1: stefan2
> > + +1 (without r1615354): brane, breser
> > +
> > * r1612225
> > Ignore ENOTIMPL and EINCOMPLETE errors when tweaking temporary file
> > permission bits on non-windows systems.
> > @@ -169,22 +185,5 @@ Veto-blocked changes:
> > the root cause is not fixed. Discussion:
> > http://svn.haxx.se/dev/archive-2014-01/0158.shtml)
> >
> > - * r1611379, r1612405
> > - Fix revprop caching initialization delays for ra_serf on Windows.
> > - Justification:
> > - Without this patch, even small checkouts may take 20 to 40
> > - seconds longer. This patch switches the named atomics SHM
> > - initialization guard to the same "never delete the lock file"
> > - pattern that we use for FSFS-internal locks.
> > - Notes:
> > - Branch is needed since SVN_VA_NULL is not available in 1.8.x.
> > - Same goes for svn_io_file_create_empty.
> > - Branch:
> > - ^/subversion/branches/1.8.x-r1611379
> > - Votes:
> > - +1: stefan2, brane, breser
> > - -1: ivan (Race condition and undefined behavior. See:
> > - http://svn.haxx.se/dev/archive-2014-08/0007.shtml)
> Why did you remove my veto for this nomination??
Because it is outdated. But I'm not sure about the exact process here.
> Please add it back.
>
Done.
-- Stefan^2.
Re: svn commit: r1616696 - /subversion/branches/1.8.x/STATUS
Posted by Branko Čibej <br...@wandisco.com>.
On 08.08.2014 11:41, Ivan Zhakov wrote:
> On 8 August 2014 13:03, <st...@apache.org> wrote:
>> Author: stefan2
>> Date: Fri Aug 8 09:03:29 2014
>> New Revision: 1616696
>>
> Why did you remove my veto for this nomination?? Please add it back.
Indeed. Stefan, you can't just go around removing people's votes. I
expect Ivan will do that himself, once he's reviewed your fix.
-- Brane
--
Branko Čibej | Director of Subversion
WANdisco | Realising the impossibilities of Big Data
e. brane@wandisco.com
Re: svn commit: r1616696 - /subversion/branches/1.8.x/STATUS
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 8 August 2014 13:03, <st...@apache.org> wrote:
> Author: stefan2
> Date: Fri Aug 8 09:03:29 2014
> New Revision: 1616696
>
> URL: http://svn.apache.org/r1616696
> Log:
> * 1.8.x/STATUS:
> Add r1615354 to r1611379 group and unveto the latter.
>
> Modified:
> subversion/branches/1.8.x/STATUS
>
> Modified: subversion/branches/1.8.x/STATUS
> URL: http://svn.apache.org/viewvc/subversion/branches/1.8.x/STATUS?rev=1616696&r1=1616695&r2=1616696&view=diff
> ==============================================================================
> --- subversion/branches/1.8.x/STATUS (original)
> +++ subversion/branches/1.8.x/STATUS Fri Aug 8 09:03:29 2014
> @@ -133,6 +133,22 @@ Candidate changes:
> Votes:
> +1: breser, philip
>
> + * r1611379, r1612405, r1615354
> + Fix revprop caching initialization delays for ra_serf on Windows.
> + Justification:
> + Without this patch, even small checkouts may take 20 to 40
> + seconds longer. This patch switches the named atomics SHM
> + initialization guard to the same "never delete the lock file"
> + pattern that we use for FSFS-internal locks.
> + Notes:
> + Branch is needed since SVN_VA_NULL is not available in 1.8.x.
> + Same goes for svn_io_file_create_empty.
> + Branch:
> + ^/subversion/branches/1.8.x-r1611379
> + Votes:
> + +1: stefan2
> + +1 (without r1615354): brane, breser
> +
> * r1612225
> Ignore ENOTIMPL and EINCOMPLETE errors when tweaking temporary file
> permission bits on non-windows systems.
> @@ -169,22 +185,5 @@ Veto-blocked changes:
> the root cause is not fixed. Discussion:
> http://svn.haxx.se/dev/archive-2014-01/0158.shtml)
>
> - * r1611379, r1612405
> - Fix revprop caching initialization delays for ra_serf on Windows.
> - Justification:
> - Without this patch, even small checkouts may take 20 to 40
> - seconds longer. This patch switches the named atomics SHM
> - initialization guard to the same "never delete the lock file"
> - pattern that we use for FSFS-internal locks.
> - Notes:
> - Branch is needed since SVN_VA_NULL is not available in 1.8.x.
> - Same goes for svn_io_file_create_empty.
> - Branch:
> - ^/subversion/branches/1.8.x-r1611379
> - Votes:
> - +1: stefan2, brane, breser
> - -1: ivan (Race condition and undefined behavior. See:
> - http://svn.haxx.se/dev/archive-2014-08/0007.shtml)
Why did you remove my veto for this nomination?? Please add it back.
--
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com