[GitHub] [arrow-datafusion] sarutak commented on a diff in pull request #7674: Upgrade apache-avro to 0.16

["sarutak (via GitHub)" <gi...@apache.org>]

sarutak commented on code in PR #7674:
URL: https://github.com/apache/arrow-datafusion/pull/7674#discussion_r1338838948


##########
datafusion/core/src/datasource/avro_to_arrow/schema.rs:
##########
@@ -158,6 +159,8 @@ fn schema_to_field_with_props(
         AvroSchema::TimeMicros => DataType::Time64(TimeUnit::Microsecond),
         AvroSchema::TimestampMillis => DataType::Timestamp(TimeUnit::Millisecond, None),
         AvroSchema::TimestampMicros => DataType::Timestamp(TimeUnit::Microsecond, None),
+        AvroSchema::LocalTimestampMillis => todo!(),

Review Comment:
   Type conversion from `LocalTimestamp` is not trivial. So leave them as `todo!()` now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org