[GitHub] [arrow-datafusion] waitingkuo commented on pull request #4156: Full support for time32 and time64 literal values (`ScalarValue`)

[GitBox <gi...@apache.org>]

waitingkuo commented on PR #4156:
URL: https://github.com/apache/arrow-datafusion/pull/4156#issuecomment-1311270098

   @alamb  @andre-cc-natzka 
   out of bound value make the casting crash, i think it's worth fixing as well. Perhaps another follow on issue/pr to fix
   
   ```bash
   ➜  datafusion-cli git:(Support_Time32_and_Time64) ✗ cargo run
       Finished dev [unoptimized + debuginfo] target(s) in 0.48s
        Running `target/debug/datafusion-cli`
   DataFusion CLI v13.0.0
   ❯ select 86400000000000::time;
   thread 'main' panicked at 'invalid time', /Users/willy/.cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.22/src/naive/time/mod.rs:422:67
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   ```
   
   ```bash
   ➜  datafusion-cli git:(Support_Time32_and_Time64) ✗ cargo run
       Finished dev [unoptimized + debuginfo] target(s) in 0.46s
        Running `target/debug/datafusion-cli`
   DataFusion CLI v13.0.0
   ❯ select (-1)::time;
   thread 'main' panicked at 'invalid time', /Users/willy/.cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.22/src/naive/time/mod.rs:422:67
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org