[GitHub] [superset] junlincc edited a comment on pull request #12992: feat(native-filters): Time native filter

[GitBox <gi...@apache.org>]

junlincc edited a comment on pull request #12992:
URL: https://github.com/apache/superset/pull/12992#issuecomment-775227962


   @simcha90 thanks for taking over the project! really appreciate you work
   
   tested and the basic functionality is working, can not fully test until the filter is connected to the indicator. @zhaoyongjie we should either skip the time column select or pre-select dttm column for your user, or simply narrow it down to show date column only in select dropdown. 
   Also there's noticeable layout issue of regular filter on the left bar. 
   Priority fo next steps  - 
   
   1. Layout - make sure user can change filter value of regular filter (reason: we need to keep this feature in minimal demo-able state)
   <img width="244" alt="Screen Shot 2021-02-08 at 7 22 23 AM" src="https://user-images.githubusercontent.com/67837651/107240256-93e75680-69de-11eb-8fe6-c6bfd3ec5011.png">
   
   
   2. connect to filter indicator and magnifier
   
   
   3. Improve Filter Config Modal validation, populate only date/datetime/time columns in select 
   
   4. Performance 
   
   5. Inverse 
   
   https://user-images.githubusercontent.com/67837651/107239584-d9efea80-69dd-11eb-88b7-7445f9c0bb01.mov
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org