You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/26 00:20:39 UTC
[GitHub] [apisix] arthur-zhang opened a new pull request #4668: Add plugin route by header
arthur-zhang opened a new pull request #4668:
URL: https://github.com/apache/apisix/pull/4668
### What this PR does / why we need it:
Add new plugin to support Header Based Routing, no need to add new route
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] arthur-zhang commented on a change in pull request #4668: feat: Add plugin route by header
Posted by GitBox <gi...@apache.org>.
arthur-zhang commented on a change in pull request #4668:
URL: https://github.com/apache/apisix/pull/4668#discussion_r676312944
##########
File path: apisix/plugins/header-based-routing.lua
##########
@@ -0,0 +1,175 @@
+--
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4668: feat: Add plugin route by header
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4668:
URL: https://github.com/apache/apisix/pull/4668#discussion_r676230077
##########
File path: apisix/plugins/header-based-routing.lua
##########
@@ -0,0 +1,175 @@
+--
Review comment:
Why not add it to traffic-split plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #4668: feat: Add plugin route by header
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #4668:
URL: https://github.com/apache/apisix/pull/4668#issuecomment-886292392
It looks like another traffic-split plugin, why not just enhance that one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] arthur-zhang closed pull request #4668: feat: Add plugin route by header
Posted by GitBox <gi...@apache.org>.
arthur-zhang closed pull request #4668:
URL: https://github.com/apache/apisix/pull/4668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org