You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "h-vetinari (via GitHub)" <gi...@apache.org> on 2023/07/27 01:52:13 UTC
[GitHub] [arrow] h-vetinari opened a new pull request, #36901: GH-15017: harden test_memory.py for use with ARROW_USE_GLOG=ON
h-vetinari opened a new pull request, #36901:
URL: https://github.com/apache/arrow/pull/36901
Use the fix [suggested](https://github.com/apache/arrow/issues/15017#issuecomment-1356876550) by @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36901: GH-15017: harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1652800403
```
Invalid group(s) {'conda-linux-x64-cpu-py3'}. Must be one of {'example-cpp', 'conda', 'test', 'homebrew', 'linux', 'fuzz', 'c-glib', 'verify-rc-source', 'ruby', 'integration', 'verify-rc-source-linux', 'verify-rc-source-macos', 'vcpkg', 'cpp', 'example', 'nightly-tests', 'linux-amd64', 'verify-rc-binaries', 'wheel', 'verify-rc-wheels', 'nightly-packaging', 'python', 'nightly', 'packaging', 'linux-arm64', 'verify-rc', 'example-python', 'conan', 'r', 'nightly-release', 'verify-rc-jars'}
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/5675632984
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] h-vetinari commented on pull request #36901: GH-15017: harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "h-vetinari (via GitHub)" <gi...@apache.org>.
h-vetinari commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1652799348
@github-actions crossbow submit -g conda-linux-x64-cpu-py3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36901: GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1652811843
Revision: f0fbddf010eb35a69b01c1a4cf5f367d9c7a899f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1537d49ce0](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1537d49ce0)
|Task|Status|
|----|------|
|conda-linux-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/15381444287)|
|conda-osx-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/15381443212)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36901: GH-15017: harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1652809791
@github-actions crossbow submit conda-linux-x64-cpu-py3 conda-osx-x64-cpu-py3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36901: GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1652903867
Revision: 9e394b22ef8ba51c48cfc54586ee5be2025fc112
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d5c32d8073](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d5c32d8073)
|Task|Status|
|----|------|
|conda-linux-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/15383612504)|
|conda-osx-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/15383612069)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] h-vetinari commented on pull request #36901: GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "h-vetinari (via GitHub)" <gi...@apache.org>.
h-vetinari commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1652902196
@github-actions crossbow submit conda-linux-x64-cpu-py3 conda-osx-x64-cpu-py3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36901: GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1670276104
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 47e438adf74d0c38068d9fd31fca083c650209c8.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15726569707) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36901: GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36901:
URL: https://github.com/apache/arrow/pull/36901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] h-vetinari commented on pull request #36901: GH-15017: harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "h-vetinari (via GitHub)" <gi...@apache.org>.
h-vetinari commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1652801658
I don't want to run the full barrage of conda-tests here to verify that the tests passes when glog is enabled. One run of `conda-{linux,osx}-x64-cpu-py3` would be enough, but I don't know how to do that with the crossbow invocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] h-vetinari commented on pull request #36901: GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "h-vetinari (via GitHub)" <gi...@apache.org>.
h-vetinari commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1654893525
Thanks for fixing the superfluous f-string! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36901: GH-15017: harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1652798433
:warning: GitHub issue #15017 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] h-vetinari commented on pull request #36901: GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "h-vetinari (via GitHub)" <gi...@apache.org>.
h-vetinari commented on PR #36901:
URL: https://github.com/apache/arrow/pull/36901#issuecomment-1653090549
@kou, this should be ready IMO - at least, I couldn't find anything in the linter job that's related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #36901: GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36901:
URL: https://github.com/apache/arrow/pull/36901#discussion_r1276995625
##########
python/pyarrow/tests/test_memory.py:
##########
@@ -134,8 +134,14 @@ def check_env_var(name, expected, *, expect_warning=False):
res.check_returncode() # fail
errlines = res.stderr.splitlines()
if expect_warning:
- assert len(errlines) == 1
- assert f"Unsupported backend '{name}'" in errlines[0]
+ assert len(errlines) in (1, 2)
+ if len(errlines) == 1:
+ # ARROW_USE_GLOG=OFF
+ assert f"Unsupported backend '{name}'" in errlines[0]
+ else:
+ # ARROW_USE_GLOG=ON
+ assert f"InitGoogleLogging()" in errlines[0]
Review Comment:
```suggestion
assert "InitGoogleLogging()" in errlines[0]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org