[GitHub] [phoenix] stoty commented on a change in pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…

[GitBox <gi...@apache.org>]

stoty commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561708911



##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
         <hbase.version>${hbase-2.3.runtime.version}</hbase.version>
         <hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
         <zookeeper.version>3.5.7</zookeeper.version>
+        <hadoop.version>3.1.3</hadoop.version>

Review comment:
       3.1.2 is not the latest version it supports, it's just the default. (Even HBase branch-2.4 and master uses Hadoop 3.1.2 as default)
   There seems to be no problem with using Hadoop 3.1.3 with Hbase 2.2 and 2.3, nor with using 3.1.4 with 2.4.
   
   On one hand, we get bug, security and performance fixes when using a later (compatible) version.
   
   On the other hand, simply sticking to the Hbase default version also has merit, as we can avoid the kind of problems that the last upgrade has created.
   
   This only affects the defaults, and the binary distributions, end users are free to build with wathever version they choose.
   
   I am running a set of builds with HBase 2.1/2.2/2.3 and Hadoop 3.0.3/3.1.3/3.1.3 respectively, so we'll know more in about an hour.
   
   I do not have a firm opinon either way, if you think that we should simnply revert PHOENIX-6326, that is also possible.
   
   Provided that the tests with the above combinations are clean, would you prefer the 3.0.3/3.1.3/3.1.3/3.1.4 version or the old 3.0.3/3.1.2/3.1.2/3.1.2 ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org