You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/05/31 20:32:57 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2657: [GOBBLIN-792] submit a GobblinTrackingEvent when jobs are compiled but not yet orchestrated

sv2000 commented on a change in pull request #2657: [GOBBLIN-792] submit a GobblinTrackingEvent when jobs are compiled but not yet orchestrated
URL: https://github.com/apache/incubator-gobblin/pull/2657#discussion_r289537827
 
 

 ##########
 File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowStatusResource.java
 ##########
 @@ -186,7 +186,8 @@ static ExecutionStatus updatedFlowExecutionStatus(ExecutionStatus jobExecutionSt
     if (currentFlowExecutionStatus == ExecutionStatus.RUNNING ||
         jobExecutionStatus == ExecutionStatus.RUNNING ||
         jobExecutionStatus == ExecutionStatus.ORCHESTRATED ||
-        jobExecutionStatus == ExecutionStatus.COMPILED) {
+        jobExecutionStatus == ExecutionStatus.COMPILED ||
+        jobExecutionStatus == ExecutionStatus.PENDING) {
 
 Review comment:
   This does not look right. A Pending job is not in running state yet, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services