[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3510: [ZEPPELIN-4416]. Don't merge properties from inteprreter-setting.json if it already exists

[GitBox <gi...@apache.org>]

liuxunorg commented on a change in pull request #3510: [ZEPPELIN-4416]. Don't merge properties from inteprreter-setting.json if it already exists
URL: https://github.com/apache/zeppelin/pull/3510#discussion_r344541664
 
 

 ##########
 File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
 ##########
 @@ -245,26 +245,11 @@ private void loadFromFile() throws IOException {
 
       InterpreterSetting interpreterSettingTemplate =
           interpreterSettingTemplates.get(savedInterpreterSetting.getGroup());
-      // InterpreterSettingTemplate is from interpreter-setting.json which represent the latest
+      // InterpreterSettingTemplate is from interpreter-setting.json which represent the initialized
       // InterpreterSetting, while InterpreterSetting is from interpreter.json which represent
       // the user saved interpreter setting
       if (interpreterSettingTemplate != null) {
-        savedInterpreterSetting.setInterpreterDir(interpreterSettingTemplate.getInterpreterDir());
 
 Review comment:
   ```
   savedInterpreterSetting.setInterpreterDir(interpreterSettingTemplate.getInterpreterDir());
   ```
   This `setInterpreterDir()` property is not copied in `InterpreterSetting.java` above.
   Can this line of code be deleted?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services