You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dan Fabulich (JIRA)" <ji...@codehaus.org> on 2007/12/08 00:07:57 UTC
[jira] Created: (MSHADE-7) Shade should generate code, not replace
the jar
Shade should generate code, not replace the jar
-----------------------------------------------
Key: MSHADE-7
URL: http://jira.codehaus.org/browse/MSHADE-7
Project: Maven 2.x Shade Plugin
Issue Type: Improvement
Reporter: Dan Fabulich
I frequently get errors replacing the output jar. (That's MSHADE-5.) It seems to me that it would be better if shade operated during the generate-sources phase, dropping the generated dependencies into a target/generated-sources directory.
That way I could write my code directly against the shaded classes (rather than requiring shade do do the extra work of shading me as well).
That would have the benefit of not needing to replace the artifact at package time, knocking out MSHADE-5, and making MSHADE-6 irrelevant as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHADE-7) Shade should generate code, not
replace the jar
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116518 ]
Dan Fabulich commented on MSHADE-7:
-----------------------------------
MSHADE-7 is a very different feature from shadedArtifactAttached.
MSHADE-7 suggests that the generated classes just get dumped in with the regular classes, so I can just write my code directly against the shaded packages.
In that case, there would be no separate shaded artifact; the main artifact would be the only artifact, and no need to replace.
shadedArtifactAttached appends a new artifact with -shaded classifier, which isn't as helpful because the non-shaded artifact is usually trash.
> Shade should generate code, not replace the jar
> -----------------------------------------------
>
> Key: MSHADE-7
> URL: http://jira.codehaus.org/browse/MSHADE-7
> Project: Maven 2.x Shade Plugin
> Issue Type: Improvement
> Reporter: Dan Fabulich
>
> I frequently get errors replacing the output jar. (That's MSHADE-5.) It seems to me that it would be better if shade operated during the generate-sources phase, dropping the generated dependencies into a target/generated-sources directory.
> That way I could write my code directly against the shaded classes (rather than requiring shade do do the extra work of shading me as well).
> That would have the benefit of not needing to replace the artifact at package time, knocking out MSHADE-5, and making MSHADE-6 irrelevant as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSHADE-7) Shade should generate code, not replace
the jar
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MSHADE-7.
----------------------------------
Resolution: Won't Fix
Assignee: Benjamin Bentmann
The proposed workflow doesn't play nicely with IDE tooling which creates the class path from the (non-shaded!) dependencies specified in the POM.
> Shade should generate code, not replace the jar
> -----------------------------------------------
>
> Key: MSHADE-7
> URL: http://jira.codehaus.org/browse/MSHADE-7
> Project: Maven 2.x Shade Plugin
> Issue Type: Improvement
> Reporter: Dan Fabulich
> Assignee: Benjamin Bentmann
>
> I frequently get errors replacing the output jar. (That's MSHADE-5.) It seems to me that it would be better if shade operated during the generate-sources phase, dropping the generated dependencies into a target/generated-sources directory.
> That way I could write my code directly against the shaded classes (rather than requiring shade do do the extra work of shading me as well).
> That would have the benefit of not needing to replace the artifact at package time, knocking out MSHADE-5, and making MSHADE-6 irrelevant as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHADE-7) Shade should generate code, not
replace the jar
Posted by "Mauro Talevi (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116471 ]
Mauro Talevi commented on MSHADE-7:
-----------------------------------
Dan, have you tried configuring a shaded attached artifact - as in src/test/projects/shaded-attached-project?
That will create a new jar instead of replacing the original artifact.
> Shade should generate code, not replace the jar
> -----------------------------------------------
>
> Key: MSHADE-7
> URL: http://jira.codehaus.org/browse/MSHADE-7
> Project: Maven 2.x Shade Plugin
> Issue Type: Improvement
> Reporter: Dan Fabulich
>
> I frequently get errors replacing the output jar. (That's MSHADE-5.) It seems to me that it would be better if shade operated during the generate-sources phase, dropping the generated dependencies into a target/generated-sources directory.
> That way I could write my code directly against the shaded classes (rather than requiring shade do do the extra work of shading me as well).
> That would have the benefit of not needing to replace the artifact at package time, knocking out MSHADE-5, and making MSHADE-6 irrelevant as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira