You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by rip-nsk <gi...@git.apache.org> on 2017/12/05 01:26:48 UTC
[GitHub] orc pull request #197: ORCORC-271: Improve HAS_PRE_1970/HAS_POST_2038 code
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/197
ORCORC-271: Improve HAS_PRE_1970/HAS_POST_2038 code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-271
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/197.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #197
----
commit e5eef3c08174bb628d3eb02e86b192bb8cc64fc9
Author: rip.nsk <ri...@gmail.com>
Date: 2017-12-05T00:34:36Z
Improve HAS_PRE_1970 check and fix dependent tests
Signed-off-by: rip-nsk <ri...@gmail.com>
commit 7f63a0cc4a0366c0dce5bdaf38acc52659d02e5d
Author: rip.nsk <ri...@gmail.com>
Date: 2017-12-05T00:35:46Z
Simplify HAS_POST_2038 check.
Signed-off-by: rip-nsk <ri...@gmail.com>
----
---
[GitHub] orc issue #197: ORCORC-271: Improve HAS_PRE_1970/HAS_POST_2038 code
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/197
Your HAS_POST_2038 doesn't do the correct test.
The point of the HAS_POST_2038 isn't that gmtime fails, it is that the timezone information continues in 2038. MacOS is the last hold out using the old 32 bit timezone files.
So the current test uses Americas/Los_Angeles and checks to see if daylight savings happens in 2038. Your test for HAS_POST_2038 erroneously passes on MacOS.
---
[GitHub] orc issue #197: ORCORC-271: Improve HAS_PRE_1970/HAS_POST_2038 code
Posted by rip-nsk <gi...@git.apache.org>.
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/197
Change in HAS_POST_2038 shows the bug in osx/clang build:
/Users/travis/build/apache/orc/tools/test/TestMatch.cc:149: Failure
Expected: expectedLine
Which is: "{\"time\": \"2038-05-05 12:34:56.1\", \"date\": \"2038-12-25\"}"
To be equal to: line
Which is: "{\"time\": \"2038-05-05 11:34:56.1\", \"date\": \"2038-12-25\"}"
wrong output at row 0
---
[GitHub] orc pull request #197: ORC-271: [C++] Improve HAS_PRE_1970 code
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/197
---
[GitHub] orc issue #197: ORCORC-271: Improve HAS_PRE_1970/HAS_POST_2038 code
Posted by rip-nsk <gi...@git.apache.org>.
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/197
'Simplify HAS_POST_2038 check' commit is reverted.
---