You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/14 14:58:55 UTC
[GitHub] [iceberg] rdblue opened a new pull request, #5034: Core: Fix tag ancestor snapshot handling
rdblue opened a new pull request, #5034:
URL: https://github.com/apache/iceberg/pull/5034
This fixes the expiration for snapshots that are ancestors of tags. Tag ancestors should not be considered "referenced" snapshots and should be cleaned up using the global table settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks merged pull request #5034: Core: Fix tag ancestor snapshot handling
Posted by GitBox <gi...@apache.org>.
danielcweeks merged PR #5034:
URL: https://github.com/apache/iceberg/pull/5034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on pull request #5034: Core: Fix tag ancestor snapshot handling
Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar commented on PR #5034:
URL: https://github.com/apache/iceberg/pull/5034#issuecomment-1155427881
Thanks for catching this I missed this in https://github.com/amogh-jahagirdar/iceberg/pull/1/files
Looks like there are some checkstyle errors in TestRemoveSnapshots but other than that looks good to me!
[Error: Checkstyle] [ERROR] /home/runner/work/iceberg/iceberg/core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:34:1: Extra separation in import group before 'java.io.IOException' [ImportOrder]
Error: eckstyle] [ERROR] /home/runner/work/iceberg/iceberg/core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:34:1: Wrong order for 'java.io.IOException' import. [ImportOrder]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5034: Core: Fix tag ancestor snapshot handling
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5034:
URL: https://github.com/apache/iceberg/pull/5034#issuecomment-1166064714
@namrathamyske, when a ref doesn't have a max snapshot age, the branch will use the `expireOlderThan` timestamp. That timestamp is set so that the snapshot would be aged off, except that it is referenced by the branch with effectively infinite snapshot age. We could set something smaller, but since the point is to make the branch protect that snapshot, using the highest possible age seems fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5034: Core: Fix tag ancestor snapshot handling
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5034:
URL: https://github.com/apache/iceberg/pull/5034#issuecomment-1155311035
@amogh-jahagirdar, can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] namrathamyske commented on pull request #5034: Core: Fix tag ancestor snapshot handling
Posted by GitBox <gi...@apache.org>.
namrathamyske commented on PR #5034:
URL: https://github.com/apache/iceberg/pull/5034#issuecomment-1164885578
@rdblue Why do we need to set `setMaxSnapshotAgeMs("branch", Long.MAX_VALUE)` in the test case ? anyway the snapshots still referenced by a branch will be added to referenced snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org