You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Bharath Mundlapudi (JIRA)" <ji...@apache.org> on 2011/04/01 10:04:05 UTC
[jira] [Created] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Distribute TaskTracker userlogs onto multiple disks
---------------------------------------------------
Key: MAPREDUCE-2415
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
Project: Hadoop Map/Reduce
Issue Type: Improvement
Components: task-controller, tasktracker
Affects Versions: 0.20.204.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
Fix For: 0.20.204.0
Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014474#comment-13014474 ]
Ravi Gummadi commented on MAPREDUCE-2415:
-----------------------------------------
>> to strengthen TaskTracker reliability w.r.t disk failures.
In addition to that, user logs can grow to bigger sizes and can stay alive for more time by setting mapred.userlog.retain.hours to higher value because of spreading them on to multiple disks.
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Bharath Mundlapudi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bharath Mundlapudi updated MAPREDUCE-2415:
------------------------------------------
Attachment: MAPREDUCE-2415-1.patch
Attaching the patch.
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022210#comment-13022210 ]
Owen O'Malley commented on MAPREDUCE-2415:
------------------------------------------
Bhrath,
Can you run test-patch on this patch?
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, MAPREDUCE-2415-2.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Bharath Mundlapudi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022619#comment-13022619 ]
Bharath Mundlapudi commented on MAPREDUCE-2415:
-----------------------------------------------
Owen,
I have run ant test-patch. Most of the things seems fine - no javac warnings or findbugs errors.
But found two minor javadoc warnings. I am attaching a patch which fixes these warnings.
You will see the following in the diff b/w these two (v2 and v3) patches:
< + * @param TaskAttemptID ID of the task
---
> + * @param taskID ID of the task
< + * @return
---
> + * @return target task attempt log directory
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, MAPREDUCE-2415-2.patch, MAPREDUCE-2415-3.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Bharath Mundlapudi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bharath Mundlapudi updated MAPREDUCE-2415:
------------------------------------------
Attachment: TaskTracker Userlogs Design.pdf
Attaching the design document.
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015483#comment-13015483 ]
Owen O'Malley commented on MAPREDUCE-2415:
------------------------------------------
It looks like you'll have undefined references when you goto cleanup. In general you should free the memory when you are done with it rather than moving the frees to a cleanup.
Part of getting this code (or any important C/C++ code) correct requires testing and running in valgrind. Run both the unit tests and manual tests with valgrind, in particular looking at the failure cases and fixing all of the undefined memory references and unfreed memory.
Use stdbool.h instead of defining your own.
You have tabs instead of all spaces.
I think it would be clearer to replace the code that traverses the link with code that does:
rm link
foreach dir: goodir
rm dir
The reinitialization code needs to delete old user logs that are no longer pointed to by a symlink. This is easier given the change above.
You should create a new method createLogDir in TaskController rather than testing the type in an if statement.
You need to update the unit tests to test the new functionality.
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Bharath Mundlapudi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bharath Mundlapudi updated MAPREDUCE-2415:
------------------------------------------
Attachment: MAPREDUCE-2415-2.patch
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, MAPREDUCE-2415-2.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Bharath Mundlapudi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bharath Mundlapudi updated MAPREDUCE-2415:
------------------------------------------
Attachment: MAPREDUCE-2415-3.patch
Attaching the updated patch for javadoc warnings.
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, MAPREDUCE-2415-2.patch, MAPREDUCE-2415-3.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Bharath Mundlapudi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017671#comment-13017671 ]
Bharath Mundlapudi commented on MAPREDUCE-2415:
-----------------------------------------------
Thanks for the code review, Owen. Attached a revised patch which incorporates your comments.
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, MAPREDUCE-2415-2.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015539#comment-13015539 ]
Owen O'Malley commented on MAPREDUCE-2415:
------------------------------------------
I'd also change the "Invalid local dir count" error message to "No valid local directories."
I'd also add an error message in get_nth_local_dir to say, "Invalid index %d for %d local directories."
With those two covered, you don't need to include the log for "Invalid local dir."
It looks like the new error messages in initialize_job after calling open_file_as_task_tracker will produce duplicated messages. Same after change_user.
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley resolved MAPREDUCE-2415.
--------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
I just committed this to 204. Thanks, Bharath!
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, MAPREDUCE-2415-2.patch, MAPREDUCE-2415-3.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2415) Distribute TaskTracker userlogs
onto multiple disks
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated MAPREDUCE-2415:
-----------------------------------
Issue Type: Sub-task (was: Improvement)
Parent: MAPREDUCE-2657
> Distribute TaskTracker userlogs onto multiple disks
> ---------------------------------------------------
>
> Key: MAPREDUCE-2415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2415
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: task-controller, tasktracker
> Affects Versions: 0.20.204.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: MAPREDUCE-2415-1.patch, MAPREDUCE-2415-2.patch, MAPREDUCE-2415-3.patch, TaskTracker Userlogs Design.pdf
>
>
> Currently, userlogs directory in TaskTracker is placed under hadoop.log.dir like <hadoop.log.dir>/userlogs. I am proposing to spread these userlogs onto multiple configured mapred.local.dirs to strengthen TaskTracker reliability w.r.t disk failures.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira