[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8824: Re-enable pylint for superset/connectors/base/models.py

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #8824: Re-enable pylint for superset/connectors/base/models.py
URL: https://github.com/apache/incubator-superset/pull/8824#discussion_r357732908
 
 

 ##########
 File path: superset/connectors/base/models.py
 ##########
 @@ -130,8 +131,7 @@ def url(self) -> str:
     def explore_url(self) -> str:
         if self.default_endpoint:
             return self.default_endpoint
-        else:
-            return "/superset/explore/{obj.type}/{obj.id}/".format(obj=self)
+        return "/superset/explore/{obj.type}/{obj.id}/".format(obj=self)
 
 Review comment:
   Can we use f strings here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org