[GitHub] spark pull request #19061: [SPARK-21568][CORE] ConsoleProgressBar should onl...

[dongjoon-hyun <gi...@git.apache.org>]

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19061#discussion_r142420371
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -434,7 +434,7 @@ class SparkContext(config: SparkConf) extends Logging {
         _statusTracker = new SparkStatusTracker(this)
     
         _progressBar =
    -      if (_conf.getBoolean("spark.ui.showConsoleProgress", true) && !log.isInfoEnabled) {
    +      if (_conf.getBoolean("spark.ui.showConsoleProgress", false) && !log.isInfoEnabled) {
    --- End diff --
    
    Now, the default value is false. However, `SparkSubmit` will inject 'true' if `spark.ui.showConsoleProgress` is not defined in our Shell environments.
    
    The original issue was the default behavior of this option. This PR solves that. If you want to stop users from using this option in order to enable `ConsoleProgressBar`, we also are able to change this config completely into some internal one, `spark.internal.ui.showConsoleProgress` in this `SparkContext` class.  In that case, `spark.ui.showConsoleProgress` will converted into `spark.internal.ui.showConsoleProgress` in `SparkSubmit`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org