You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/21 12:32:28 UTC
[GitHub] [arrow-datafusion] alamb opened a new issue #376: Combine GroupByScalar and ScalarValue
alamb opened a new issue #376:
URL: https://github.com/apache/arrow-datafusion/issues/376
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
There is non trivial overlap of similar, but not quite the same features in `GroupByScalar` and `ScalarValue `
As discussed on https://github.com/apache/arrow-datafusion/issues/364#issuecomment-844401489 we think this is an historical artifact and the code would be simpler / have fewer bugs if they were combined.
**Describe the solution you'd like**
COmbine the two classes (into ScalarValue)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #376: Combine GroupByScalar and ScalarValue
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #376:
URL: https://github.com/apache/arrow-datafusion/issues/376#issuecomment-888241659
One thing we have discovered while working on #768 is that the size of GroupByScalar is 16 bytes while ScalarValue is larger (currently 64 bytes but with #788 it could be 32 bytes).
Another difference is that GroupByScalar has no way to represent "NULL" (and thus at the moment hash aggregates also do not support grouping by NULL)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #376: Combine GroupByScalar and ScalarValue
Posted by GitBox <gi...@apache.org>.
alamb closed issue #376:
URL: https://github.com/apache/arrow-datafusion/issues/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org