You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/26 17:02:36 UTC
[GitHub] [superset] AnaKuzina opened a new issue #14848: Translations files don't translate everything
AnaKuzina opened a new issue #14848:
URL: https://github.com/apache/superset/issues/14848
Hello! I've modified Russian translations files.
Everything worked great except header tabs and some menu data ("Data", "Charts" in headers tabs, "Manage" in Settings dropdown etc.).
I don't understand what the problem is. Will appreciate any help, thanks!
<img width="706" alt="Снимок экрана 2021-05-26 в 19 59 17" src="https://user-images.githubusercontent.com/21035768/119701394-f284f300-be5c-11eb-8c6e-faee1cb6dbb8.png">
<img width="245" alt="Снимок экрана 2021-05-26 в 19 59 30" src="https://user-images.githubusercontent.com/21035768/119701387-f153c600-be5c-11eb-81c9-e22ef5c0c775.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849615527
Hi,AnaKuzina
I don t know Russian sync grammar but by Chinese grammar the translation in Russian meassage.mo file has many punctuation errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-850468067
Hi，
The word translation here needs to find the correct word translation in the front end file, or directly modify in the front end file, it is very troublesome!
The location of the front-end file in superset\static\assets, recommends finding modifications with pycharm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack edited a comment on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack edited a comment on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849595765
This is my ru Language screenshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AnaKuzina commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
AnaKuzina commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-850429281
@xch-jack hi! Thank you for your help yesterday, I've figured it out and it works.
But now I have another problem.
These buttons: "+ dashboard", "+ chart" and other on the main page are not translated. I don't see these strings in .po file as well. Do you know what can be the problem?
<img width="1414" alt="Снимок экрана 2021-05-28 в 16 42 46" src="https://user-images.githubusercontent.com/21035768/119992981-c344c200-bfd3-11eb-8c9b-32fc1328097b.png">
Thank you in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack edited a comment on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack edited a comment on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849592659
Try modifying the meassage.mo file my screenshot location look at, which is the message.mo screenshot location you gave me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AnaKuzina commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
AnaKuzina commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849619005
@xch-jack thank you for your help! I just don't understand why the easiest line aren't translated such as **Datasets** and **Manage** - there cannot be any punctuation errors.
I don't understand what is wrong on your screenshot with two wrong sentences... I will look through other languages as an example, thank you for the advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-850535803
I give an example that if you are using Pycharm, you can find "VIEW ALL", in the front end file you can find the location you want in your screenshot, there are generally 3 JS files. And this "VIEW ALL" actual word may be lower case may be capital, all you need to understand the front-end file to do the translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849514242
Hi，
Open your messages.json file, view the last line, and cannot add a comma.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack edited a comment on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack edited a comment on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849592659
I don't know Russian syntax, but you can try viewing file comparisons in other languages.
Try modifying the meassage.mo file my screenshot location look at, which is the message.mo screenshot location you gave me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack edited a comment on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack edited a comment on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849302963
Hi，
AnaKuzina
There are punctuation errors in your translation file, please check carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-850527478
Hi，
With Docker runtime your front end file is just under superset\static\assets. It is troublesome to modify completely, and you need to find the translated words yourself in the front-end file to modify more places.
There are many places that actually need translation and you have to understand front end files to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hbruch commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
hbruch commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-1001407559
@AnaKuzina some of the untranslated messages should be translatable now via #17525.
Another issue is that docker-compose-non-dev.yml's apacha/superset:latest-dev image is built without a babel-compile step. I'll shortly submit a PR fixing this.
Finally, there are some i.e. chart related messages which are not yet covered by the babel extraction process, which will hopefully be fixed as soon as the monorepo migration is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AnaKuzina commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
AnaKuzina commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849479640
> Hi，
> AnaKuzina
> There are punctuation errors in your translation file, please check carefully.
Hi, @xch-jack
Can you please specify what type of punctuation error do I have? Do I need to exactly repeat every tab, spaces and comma that contains english string?
For example, I've translated like this:
> msgid ""
> "Encountered invalid NULL spatial "
> "entry, please consider filtering "
> "those out"
> msgstr ""
> "Обнаружена недопустимая пространственная запись NULL, "
> "пожалуйста, рассмотрите возможность её фильтрации"
Is there any punctuation errors?
And I don't understand why most of the files are translated correctly.
Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849595765
This is my ru Language screenshot.It should be the screenshot in the meassage.mo file you gave to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849302963
Hi，
AnaKuzina
There are punctuation problems in your translation file, please check carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack removed a comment on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack removed a comment on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849595765
This is my ru Language screenshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849592659
Try modifying the meassage.mo file my screenshot location look at, which is the message.mo screenshot location you gave me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AnaKuzina commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
AnaKuzina commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-850510310
@xch-jack thank you so much! Can you please show me some example of the lines of code where the words are translated in the frontend file?
The main problem is that I use docker file that takes all frontend files etc from the main superset project. So I can't modify it because I don't have permissions =))
And I don't understand why button **+ chart** is translated, but **+ sql query** is not... meanwhile you can see translated **+ sql запрос** below...
<img width="1411" alt="Снимок экрана 2021-05-28 в 18 44 55" src="https://user-images.githubusercontent.com/21035768/120009892-29861080-bfe5-11eb-8d16-b60b4463a6ab.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AnaKuzina commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
AnaKuzina commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-849574678
@xch-jack thanks for your help!
The .json file seems to be correct, the last lines are the same as in the translations files here:
<img width="672" alt="Снимок экрана 2021-05-27 в 15 02 12" src="https://user-images.githubusercontent.com/21035768/119822611-8659cc00-befc-11eb-9d18-ca66050c3080.png">
Any idea what else can it be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xch-jack commented on issue #14848: Translations files don't translate everything
Posted by GitBox <gi...@apache.org>.
xch-jack commented on issue #14848:
URL: https://github.com/apache/superset/issues/14848#issuecomment-850546785
Of course if you do use a docker-compose-f docker-compose-non-dev.yml up installation in Docker I can do nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org