[GitHub] [flink] kgrimsby commented on pull request #20685: [FLINK-28429][python] Optimize PyFlink tests

[GitBox <gi...@apache.org>]

kgrimsby commented on PR #20685:
URL: https://github.com/apache/flink/pull/20685#issuecomment-1257563464

   Hi, doesn't this commit introduce a bug?
   
   I've tried to setup from flink release-1.16 branch and found that the changes in `pyflink/fn_execution/flink_fn_execution_pb2.py` at `DESCRIPTOR = _descriptor_pool.Default().AddSerializedFile(b'...')` will never return a descriptor since the code for `AddSerializedFile` in protbuf <3.18 has no return on that function:
   `
   def AddSerializedFile(self, serialized_file_desc_proto):
       """Adds the FileDescriptorProto and its types to this pool.
       Args:
         serialized_file_desc_proto (bytes): A bytes string, serialization of the
           :class:`FileDescriptorProto` to add.
       """
   
       # pylint: disable=g-import-not-at-top
       from google.protobuf import descriptor_pb2
       file_desc_proto = descriptor_pb2.FileDescriptorProto.FromString(
           serialized_file_desc_proto)
       self.Add(file_desc_proto)
   `
   
   Am I missing something here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org