You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Martin Cooper <ma...@apache.org> on 2005/12/11 07:12:39 UTC
[VOTE] Release Commons FileUpload 1.1-RC1
A new release of Commons FileUpload is long overdue, to say the least, and I
believe it's ready. The remaining issues are either enhancements or pending
further input. The distributions for FileUpload 1.1 Release Candidate 1 are
now available here:
http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
and the updated web site is here:
http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
--------------------------------------------------------
[ ] +1 Release Commons FileUpload 1.1
[ ] +0 not too fussed, but OK
[ ] -0 won't block, but think imperfect
[ ] -1 not until xxx is fixed
--------------------------------------------------------
Here's my own +1.
--
Martin Cooper
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Rory Winston <rw...@eircom.net>.
+1
Don Brown wrote:
>+0
>
>On 12/10/05, Martin Cooper <ma...@apache.org> wrote:
>
>
>>A new release of Commons FileUpload is long overdue, to say the least, and
>>I
>>believe it's ready. The remaining issues are either enhancements or
>>pending
>>further input. The distributions for FileUpload 1.1 Release Candidate 1
>>are
>>now available here:
>>
>>http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
>>
>>and the updated web site is here:
>>
>>http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
>>
>>--------------------------------------------------------
>>[ ] +1 Release Commons FileUpload 1.1
>>[ ] +0 not too fussed, but OK
>>[ ] -0 won't block, but think imperfect
>>[ ] -1 not until xxx is fixed
>>--------------------------------------------------------
>>
>>Here's my own +1.
>>
>>--
>>Martin Cooper
>>
>>
>>
>>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Don Brown <do...@gmail.com>.
+0
On 12/10/05, Martin Cooper <ma...@apache.org> wrote:
>
> A new release of Commons FileUpload is long overdue, to say the least, and
> I
> believe it's ready. The remaining issues are either enhancements or
> pending
> further input. The distributions for FileUpload 1.1 Release Candidate 1
> are
> now available here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
>
> and the updated web site is here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
>
> --------------------------------------------------------
> [ ] +1 Release Commons FileUpload 1.1
> [ ] +0 not too fussed, but OK
> [ ] -0 won't block, but think imperfect
> [ ] -1 not until xxx is fixed
> --------------------------------------------------------
>
> Here's my own +1.
>
> --
> Martin Cooper
>
>
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Martin Cooper <ma...@apache.org>.
On 12/11/05, Rahul Akolkar <ra...@gmail.com> wrote:
>
> +1
>
> I would, however, like to see the deprecations issued in IO 1.1
> removed from the fileupload 1.1 sources. A (minor) patch to that
> effect is available for consideration in bugzilla, item 37865 [1].
Thanks. Fixed.
--
Martin Cooper
-Rahul
>
> [1] http://issues.apache.org/bugzilla/show_bug.cgi?id=37865
>
>
> On 12/11/05, Martin Cooper <ma...@apache.org> wrote:
> > A new release of Commons FileUpload is long overdue, to say the least,
> and I
> > believe it's ready. The remaining issues are either enhancements or
> pending
> > further input. The distributions for FileUpload 1.1 Release Candidate 1
> are
> > now available here:
> >
> > http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
> >
> > and the updated web site is here:
> >
> > http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
> >
> > --------------------------------------------------------
> > [ ] +1 Release Commons FileUpload 1.1
> > [ ] +0 not too fussed, but OK
> > [ ] -0 won't block, but think imperfect
> > [ ] -1 not until xxx is fixed
> > --------------------------------------------------------
> >
> > Here's my own +1.
> >
> > --
> > Martin Cooper
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Rahul Akolkar <ra...@gmail.com>.
+1
I would, however, like to see the deprecations issued in IO 1.1
removed from the fileupload 1.1 sources. A (minor) patch to that
effect is available for consideration in bugzilla, item 37865 [1].
-Rahul
[1] http://issues.apache.org/bugzilla/show_bug.cgi?id=37865
On 12/11/05, Martin Cooper <ma...@apache.org> wrote:
> A new release of Commons FileUpload is long overdue, to say the least, and I
> believe it's ready. The remaining issues are either enhancements or pending
> further input. The distributions for FileUpload 1.1 Release Candidate 1 are
> now available here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
>
> and the updated web site is here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
>
> --------------------------------------------------------
> [ ] +1 Release Commons FileUpload 1.1
> [ ] +0 not too fussed, but OK
> [ ] -0 won't block, but think imperfect
> [ ] -1 not until xxx is fixed
> --------------------------------------------------------
>
> Here's my own +1.
>
> --
> Martin Cooper
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Stephen Colebourne <sc...@btopenworld.com>.
Niall Pemberton wrote:
> 3) I upgraded the Struts 1.2.8 example webapp with no problems, except
> I initially forgot to add the new Commons IO dependency - IMO it would
> be worth mentioning this in the official announcement if/when the 1.1
> release is approved.
And this is why I will give it a -0. My opinion is that [fileupload]
does not need to depend on [io]. We need 'bricks' that are as
independent as possible.
Note that I do agree that [fileupload] needs a new release, and that the
[io] issue has come up before and been rejected, so I'm not going to
comment further.
Stephen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Martin Cooper <ma...@apache.org>.
On 12/10/05, Niall Pemberton <ni...@gmail.com> wrote:
>
> +1 from me - I have the following minor comments:
>
> 1) On the "Issue Tracking" page the "Submit a Bug" link puts an "[io]"
> prefix in the header rather than "[fileupload]".
Fixed.
2) The links on the "Changes/Developer Activity/File Activity" report
> don't work - this is a bug in the maven plug-in - but changing the
> repository url in the project.xml to just the root apache repository
> resolves this:
>
> <repository>
> <url>http://svn.apache.org/viewcvs.cgi</url>
> </repository>
Fixed, except I used the raw SVN URL rather than viewcvs.
3) I upgraded the Struts 1.2.8 example webapp with no problems, except
> I initially forgot to add the new Commons IO dependency - IMO it would
> be worth mentioning this in the official announcement if/when the 1.1
> release is approved.
Will do. I also added a note in the release notes about this.
--
Martin Cooper
Niall
>
> On 12/11/05, Martin Cooper <ma...@apache.org> wrote:
> > A new release of Commons FileUpload is long overdue, to say the least,
> and I
> > believe it's ready. The remaining issues are either enhancements or
> pending
> > further input. The distributions for FileUpload 1.1 Release Candidate 1
> are
> > now available here:
> >
> > http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
> >
> > and the updated web site is here:
> >
> > http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
> >
> > --------------------------------------------------------
> > [ ] +1 Release Commons FileUpload 1.1
> > [ ] +0 not too fussed, but OK
> > [ ] -0 won't block, but think imperfect
> > [ ] -1 not until xxx is fixed
> > --------------------------------------------------------
> >
> > Here's my own +1.
> >
> > --
> > Martin Cooper
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Niall Pemberton <ni...@gmail.com>.
+1 from me - I have the following minor comments:
1) On the "Issue Tracking" page the "Submit a Bug" link puts an "[io]"
prefix in the header rather than "[fileupload]".
2) The links on the "Changes/Developer Activity/File Activity" report
don't work - this is a bug in the maven plug-in - but changing the
repository url in the project.xml to just the root apache repository
resolves this:
<repository>
<url>http://svn.apache.org/viewcvs.cgi</url>
</repository>
3) I upgraded the Struts 1.2.8 example webapp with no problems, except
I initially forgot to add the new Commons IO dependency - IMO it would
be worth mentioning this in the official announcement if/when the 1.1
release is approved.
Niall
On 12/11/05, Martin Cooper <ma...@apache.org> wrote:
> A new release of Commons FileUpload is long overdue, to say the least, and I
> believe it's ready. The remaining issues are either enhancements or pending
> further input. The distributions for FileUpload 1.1 Release Candidate 1 are
> now available here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
>
> and the updated web site is here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
>
> --------------------------------------------------------
> [ ] +1 Release Commons FileUpload 1.1
> [ ] +0 not too fussed, but OK
> [ ] -0 won't block, but think imperfect
> [ ] -1 not until xxx is fixed
> --------------------------------------------------------
>
> Here's my own +1.
>
> --
> Martin Cooper
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Torsten Curdt <tc...@apache.org>.
+0
cheers
--
Torsten
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Martin Cooper <ma...@apache.org>.
On 12/11/05, Phil Steitz <ph...@gmail.com> wrote:
>
> +1 Looks good.
>
> One nit, which is not worth -0 IMHO, but which you might consider.
> Both bin and src distros unpack to the same directory. Some people
> prefer the src distro to unpack to -src.
I did consider this, and swithered about it. There are good reasons to do
it, and good reasons to leave it the way it is now. Given that there are
people who want it either way, and therefore I can't win, I decided to leave
it the way it is by default. ;-)
--
Martin Cooper
This could be accomplished
> by adding
>
> <move todir="${maven.dist.src.assembly.dir}-src">
> <fileset dir="${maven.dist.src.assembly.dir}"/>
> </move>
>
> to the end of your postGoal on dist:prepare-src-filesystem.
>
> Phil
>
> On 12/10/05, Martin Cooper <ma...@apache.org> wrote:
> > A new release of Commons FileUpload is long overdue, to say the least,
> and I
> > believe it's ready. The remaining issues are either enhancements or
> pending
> > further input. The distributions for FileUpload 1.1 Release Candidate 1
> are
> > now available here:
> >
> > http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
> >
> > and the updated web site is here:
> >
> > http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
> >
> > --------------------------------------------------------
> > [ ] +1 Release Commons FileUpload 1.1
> > [ ] +0 not too fussed, but OK
> > [ ] -0 won't block, but think imperfect
> > [ ] -1 not until xxx is fixed
> > --------------------------------------------------------
> >
> > Here's my own +1.
> >
> > --
> > Martin Cooper
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Phil Steitz <ph...@gmail.com>.
+1 Looks good.
One nit, which is not worth -0 IMHO, but which you might consider.
Both bin and src distros unpack to the same directory. Some people
prefer the src distro to unpack to -src. This could be accomplished
by adding
<move todir="${maven.dist.src.assembly.dir}-src">
<fileset dir="${maven.dist.src.assembly.dir}"/>
</move>
to the end of your postGoal on dist:prepare-src-filesystem.
Phil
On 12/10/05, Martin Cooper <ma...@apache.org> wrote:
> A new release of Commons FileUpload is long overdue, to say the least, and I
> believe it's ready. The remaining issues are either enhancements or pending
> further input. The distributions for FileUpload 1.1 Release Candidate 1 are
> now available here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
>
> and the updated web site is here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
>
> --------------------------------------------------------
> [ ] +1 Release Commons FileUpload 1.1
> [ ] +0 not too fussed, but OK
> [ ] -0 won't block, but think imperfect
> [ ] -1 not until xxx is fixed
> --------------------------------------------------------
>
> Here's my own +1.
>
> --
> Martin Cooper
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons FileUpload 1.1-RC1
Posted by Martin van den Bemt <ml...@mvdb.net>.
+1..
There are just too many fixes since 2003 to NOT release :)
Mvgr,
Martin
Martin Cooper wrote:
> A new release of Commons FileUpload is long overdue, to say the least, and I
> believe it's ready. The remaining issues are either enhancements or pending
> further input. The distributions for FileUpload 1.1 Release Candidate 1 are
> now available here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
>
> and the updated web site is here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
>
> --------------------------------------------------------
> [ ] +1 Release Commons FileUpload 1.1
> [ ] +0 not too fussed, but OK
> [ ] -0 won't block, but think imperfect
> [ ] -1 not until xxx is fixed
> --------------------------------------------------------
>
> Here's my own +1.
>
> --
> Martin Cooper
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org