You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/08 11:17:01 UTC
[GitHub] [incubator-eventmesh] weihubeats commented on a diff in pull request #2509: [Enhancement] Remove redundant parameter passing
weihubeats commented on code in PR #2509:
URL: https://github.com/apache/incubator-eventmesh/pull/2509#discussion_r1043240385
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java:
##########
@@ -123,12 +123,12 @@ private String checkNotEmpty(String key) {
return value;
}
- private String checkNumeric(String key) {
- String value = configurationWrapper.getProp(key);
+ private String checkNumeric() {
+ String value = configurationWrapper.getProp(ConfKeys.KEYS_EVENTMESH_SYSID);
Review Comment:
Makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org