[GitHub] [spark] viirya commented on a change in pull request #27540: Revert "[SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue"

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #27540: Revert "[SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue"
URL: https://github.com/apache/spark/pull/27540#discussion_r377997367
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
 ##########
 @@ -719,7 +719,7 @@ object StringTrim {
 
     _FUNC_(TRAILING FROM str) - Removes the trailing space characters from `str`.
 
-    _FUNC_(str, trimStr) - Remove the leading and trailing `trimStr` characters from `str`.
+    _FUNC_(trimStr, str) - Remove the leading and trailing `trimStr` characters from `str`.
 
 Review comment:
   Hmm, this looks like a mistake at all. Seems no other feasible solution for this. I'm fine to remove it from doc. One question is shall we add some words in migration guide? Can we say we deprecate it and then we will make correct one in future version?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org